Changeset 52713

Timestamp:

02/11/2022 10:09:35 PM (3 years ago)

Author:

SergeyBiryukov

Message:

Upgrade/Install: Make sure the "Show hidden updates" button is visible and works as expected.

The ​.toggle( handler, handler ) method signature was deprecated in jQuery 1.8 and removed in jQuery 1.9.

This commit updates the click handler function to work with jQuery 1.9+.

Follow-up to [9441], [9543], [42785], [48323].

Props malinevskiy, Boniu91, SergeyBiryukov.
Merges [52644] to the 5.9 branch.
Fixes #54886.

Location:

branches/5.9

Files:

• . (modified) (1 prop)
• src/wp-admin/update-core.php (modified) (1 diff)

branches/5.9/src/wp-admin/update-core.php

@@ -207 +207 @@
         )
     );
+
     if ( $dismissed ) {
-
         $show_text = esc_js( __( 'Show hidden updates' ) );
         $hide_text = esc_js( __( 'Hide hidden updates' ) );
         ?>
-    <script type="text/javascript">
-        jQuery(function( $ ) {
-            $( 'dismissed-updates' ).show();
-            $( '#show-dismissed' ).toggle( function() { $( this ).text( '<?php echo $hide_text; ?>' ).attr( 'aria-expanded', 'true' ); }, function() { $( this ).text( '<?php echo $show_text; ?>' ).attr( 'aria-expanded', 'false' ); } );
-            $( '#show-dismissed' ).click( function() { $( '#dismissed-updates' ).toggle( 'fast' ); } );
-        });
-    </script>
+        <script type="text/javascript">
+            jQuery( function( $ ) {
+                $( '#show-dismissed' ).on( 'click', function() {
+                    var isExpanded = ( 'true' === $( this ).attr( 'aria-expanded' ) );
+
+                    if ( isExpanded ) {
+                        $( this ).text( '<?php echo $show_text; ?>' ).attr( 'aria-expanded', 'false' );
+                    } else {
+                        $( this ).text( '<?php echo $hide_text; ?>' ).attr( 'aria-expanded', 'true' );
+                    }
+
+                    $( '#dismissed-updates' ).toggle( 'fast' );
+                });
+            });
+        </script>
         <?php
         echo '<p class="hide-if-no-js"><button type="button" class="button" id="show-dismissed" aria-expanded="false">' . __( 'Show hidden updates' ) . '</button></p>';