Changeset 52718

Timestamp:

02/12/2022 01:12:22 PM (3 years ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Use file_get_contents() in wp_get_webp_info().

file_get_contents() is faster than fread(), because the PHP core can decide how to best read the remaining file; it could decide to issue just one read() call or mmap() the file first.

Per the PHP manual, file_get_contents() or stream_get_contents() is the preferred way to read the contents of a file into a string. It will use memory mapping techniques if supported by the OS to enhance performance.

Reference: ​PHP Manual: file_get_contents().

Follow-up to [50810], [52696], [52698], [52701].

Props maxkellermann.
See #55069.

File:

• trunk/src/wp-includes/media.php (modified) (1 diff)

trunk/src/wp-includes/media.php

@@ -5236 +5236 @@
     }
 
-    $handle = fopen( $filename, 'rb' );
-
-    if ( false === $handle ) {
+    $magic = file_get_contents( $filename, false, null, 0, 40 );
+
+    if ( false === $magic ) {
         return compact( 'width', 'height', 'type' );
     }
-
-    $magic = fread( $handle, 40 );
-    fclose( $handle );
 
     // Make sure we got enough bytes.