Changeset 52725 for trunk

Timestamp:

02/14/2022 02:19:10 PM (2 years ago)

Author:

SergeyBiryukov

Message:

Media: Display an error message in grid view if the attachment could not be deleted.

Previously, the attachment was silently removed from the grid but reappeared after a page reload.

Follow-up to [22869].

Props kapilpaul, costdev, mukesh27, azouamauriac, SergeyBiryukov.
Fixes #55158.

Location:

trunk/src

Files:

• js/media/views/attachment/details.js (modified) (1 diff)
• wp-includes/media.php (modified) (1 diff)

trunk/src/js/media/views/attachment/details.js

@@ -155 +155 @@
 
         if ( window.confirm( l10n.warnDelete ) ) {
-            this.model.destroy();
+            this.model.destroy( {
+                wait: true,
+                error: function() {
+                    window.alert( l10n.errorDeleting );
+                }
+            } );
+
             this.moveFocus();
         }

trunk/src/wp-includes/media.php

@@ -4483 +4483 @@
         'restoreSelected'             => __( 'Restore from Trash' ),
         'deletePermanently'           => __( 'Delete permanently' ),
+        'errorDeleting'               => __( 'Error in deleting the attachment.' ),
         'apply'                       => __( 'Apply' ),
         'filterByDate'                => __( 'Filter by date' ),