Changeset 52734 for trunk/tests/phpunit/tests/admin/includesFile.php

Timestamp:

02/15/2022 05:47:39 PM (5 years ago)

Author:

Clorith

Message:

Filesystem API: Use a temp folder for Content-Disposition files.

#38231 added support for files fetched remotely to have their filename defined by the host using the Content-Disposition header. This would then take priority over the existing temporary file name created with wp_tempnam() earlier in the process.

The change unintentionally omitted the temporary directory path used during uploads, since the wp_tempnam() function would have added it previously, so that files with this header ended up being stored in the WordPress root folder, or wp-admin folder, when triggered by WP_Cron or user interactions respectively.

This change makes sure the file path includes the temporary directory location when the header is used.

Follow-up to [51939].

Props antonynz, azouamauriac.
Fixes #55109.

File:

• trunk/tests/phpunit/tests/admin/includesFile.php (modified) (2 diffs)

trunk/tests/phpunit/tests/admin/includesFile.php

@@ -103 +103 @@
 
         /**
+         * @ticket #55109
+         * @dataProvider data_save_to_temp_directory_when_getting_filename_from_content_disposition_header
+         *
+         * @covers ::download_url
+         *
+         * @param $filter A callback containing a fake Content-Disposition header.
+         */
+        public function test_save_to_temp_directory_when_getting_filename_from_content_disposition_header( $filter ) {
+                add_filter( 'pre_http_request', array( $this, $filter ), 10, 3 );
+
+                $filename = download_url( 'url_with_content_disposition_header' );
+                $this->assertStringContainsString( get_temp_dir(), $filename );
+                $this->unlink( $filename );
+
+                remove_filter( 'pre_http_request', array( $this, $filter ) );
+        }
+
+        /**
          * Data provider for test_download_url_should_respect_filename_from_content_disposition_header.
          *
@@ -112 +130 @@
                         'path traversal'   => array( 'filter_content_disposition_header_with_filename_with_path_traversal' ),
                         'no quotes'        => array( 'filter_content_disposition_header_with_filename_without_quotes' ),
+                );
+        }
+
+        /**
+         * Data provider for test_save_to_temp_directory_when_getting_filename_from_content_disposition_header.
+         *
+         * @return array
+         */
+        public function data_save_to_temp_directory_when_getting_filename_from_content_disposition_header() {
+                return array(
+                        'valid parameters' => array( 'filter_content_disposition_header_with_filename' ),
                 );
         }