Changeset 52751

Timestamp:

02/17/2022 01:54:28 PM (3 years ago)

Author:

jorgefilipecosta

Message:

Global Styles: Fix PHP warning in WP_REST_Global_Styles_Controller if no styles exist.

There is a PHP warning in WP_REST_Global_Styles_Controller because we are assuming that every theme.json has styles property, which is not always the case.

Props ntsekouras.
Merges [52750] to the 5.9 branch.
Fixes #54900.

Location:

branches/5.9

Files:

• . (modified) (1 prop)
• src/wp-includes/rest-api/endpoints/class-wp-rest-global-styles-controller.php (modified) (1 diff)

branches/5.9/src/wp-includes/rest-api/endpoints/class-wp-rest-global-styles-controller.php

@@ -564 +564 @@
 
         if ( rest_is_field_included( 'styles', $fields ) ) {
-            $data['styles'] = $theme->get_raw_data()['styles'];
+            $raw_data = $theme->get_raw_data();
+            if ( isset( $raw_data['styles'] ) ) {
+                $data['styles'] = $raw_data['styles'];
+            }
         }