Changeset 52760

Timestamp:

02/17/2022 05:38:23 PM (3 years ago)

Author:

SergeyBiryukov

Message:

Tests: Correct the @ticket reference in a download_url() test with the Content-Disposition header.

Move the data provider next to the test, for consistency.

Follow-up to [51939], [52734].

Props azouamauriac.
See #55109.

File:

• trunk/tests/phpunit/tests/admin/includesFile.php (modified) (2 diffs)

trunk/tests/phpunit/tests/admin/includesFile.php

@@ -103 +103 @@
 
     /**
-     * @ticket #55109
+     * Data provider for test_download_url_should_respect_filename_from_content_disposition_header.
+     *
+     * @return array
+     */
+    public function data_download_url_should_respect_filename_from_content_disposition_header() {
+        return array(
+            'valid parameters' => array( 'filter_content_disposition_header_with_filename' ),
+            'path traversal'   => array( 'filter_content_disposition_header_with_filename_with_path_traversal' ),
+            'no quotes'        => array( 'filter_content_disposition_header_with_filename_without_quotes' ),
+        );
+    }
+
+    /**
+     * @ticket 55109
      * @dataProvider data_save_to_temp_directory_when_getting_filename_from_content_disposition_header
      *
@@ -118 +131 @@
 
         remove_filter( 'pre_http_request', array( $this, $filter ) );
-    }
-
-    /**
-     * Data provider for test_download_url_should_respect_filename_from_content_disposition_header.
-     *
-     * @return array
-     */
-    public function data_download_url_should_respect_filename_from_content_disposition_header() {
-        return array(
-            'valid parameters' => array( 'filter_content_disposition_header_with_filename' ),
-            'path traversal'   => array( 'filter_content_disposition_header_with_filename_with_path_traversal' ),
-            'no quotes'        => array( 'filter_content_disposition_header_with_filename_without_quotes' ),
-        );
     }