Changeset 52775

Timestamp:

02/19/2022 12:40:48 PM (3 years ago)

Author:

SergeyBiryukov

Message:

Tests: Correct the order of expected and actual values in wp_validate_boolean() tests.

This corrects the order of the parameters when used in assertions so if/when they fail the failure message is correct.

Additionally, this commit moves the test function before the data provider, for consistency with other tests.

Follow-up to [46159], [46224].

See #54725.

File:

• trunk/tests/phpunit/tests/functions/wpValidateBoolean.php (modified) (2 diffs)

trunk/tests/phpunit/tests/functions/wpValidateBoolean.php

@@ -8 +8 @@
  */
 class Tests_Functions_wpValidateBoolean extends WP_UnitTestCase {
+
+    /**
+     * Test wp_validate_boolean().
+     *
+     * @dataProvider data_provider
+     *
+     * @param mixed $test_value
+     * @param bool $expected
+     *
+     * @ticket 30238
+     * @ticket 39868
+     */
+    public function test_wp_validate_boolean( $test_value, $expected ) {
+        $this->assertSame( $expected, wp_validate_boolean( $test_value ) );
+    }
+
     /**
      * Provides test scenarios for all possible scenarios in wp_validate_boolean().
@@ -42 +58 @@
             );
     }
-
-    /**
-     * Test wp_validate_boolean().
-     *
-     * @dataProvider data_provider
-     *
-     * @param mixed $test_value
-     * @param bool $expected
-     *
-     * @ticket 30238
-     * @ticket 39868
-     */
-    public function test_wp_validate_boolean( $test_value, $expected ) {
-        $this->assertSame( wp_validate_boolean( $test_value ), $expected );
-    }
 }