Changeset 52812

Timestamp:

03/01/2022 04:05:14 PM (3 years ago)

Author:

SergeyBiryukov

Message:

Themes: Make sure the current_theme_supports-{$feature} filter is consistently applied.

Previously, the filter was not applied if there are no arguments passed to current_theme_supports().

Follow-up to [12350], [19682].

Props helgatheviking, azouamauriac, pavanpatil1, SergeyBiryukov.
Fixes #55219.

Location:

trunk

Files:

• src/wp-includes/theme.php (modified) (1 diff)
• tests/phpunit/tests/theme/support.php (modified) (1 diff)

trunk/src/wp-includes/theme.php

@@ -3038 +3038 @@
     }
 
-    // If no args passed then no extra checks need be performed.
+    // If no args passed then no extra checks need to be performed.
     if ( ! $args ) {
-        return true;
+        /** This filter is documented in wp-includes/theme.php */
+        return apply_filters( "current_theme_supports-{$feature}", true, $args, $_wp_theme_features[ $feature ] ); // phpcs:ignore WordPress.NamingConventions.ValidHookName.UseUnderscores
     }
 

trunk/tests/phpunit/tests/theme/support.php

@@ -169 +169 @@
 
     /**
+     * @ticket 55219
+     */
+    public function test_plugin_hook_with_no_args() {
+        add_theme_support( 'foobar' );
+
+        add_filter( 'current_theme_supports-foobar', '__return_false' );
+
+        $this->assertFalse( current_theme_supports( 'foobar' ) );
+    }
+
+    /**
      * @ticket 26900
      */