Changeset 52823 for trunk/tests/phpunit/tests/user/capabilities.php

Timestamp:

03/06/2022 04:09:06 PM (4 years ago)

Author:

SergeyBiryukov

Message:

Users: Bring some consistency to user role hooks.

This standardizes the actions that one needs to hook to for tracking user role changes:

• add_user_role is only fired when the user has actually gained a new role.
• remove_user_role is only fired when the role was actually removed.

Both actions are now fired in WP_User::set_role() as appropriate.

Props dd32, SergeyBiryukov.
Fixes #54164.

File:

• trunk/tests/phpunit/tests/user/capabilities.php (modified) (1 diff)

trunk/tests/phpunit/tests/user/capabilities.php

@@ -1624 +1624 @@
         $caps = $user->caps;
         $this->assertNotEmpty( $user->caps );
+
         $user->set_role( 'administrator' );
         $this->assertNotEmpty( $user->caps );
         $this->assertSame( $caps, $user->caps );
+    }
+
+    /**
+     * @ticket 54164
+     */
+    public function test_set_role_fires_remove_user_role_and_add_user_role_hooks() {
+        $user = self::$users['administrator'];
+
+        $remove_user_role = new MockAction();
+        $add_user_role    = new MockAction();
+        add_action( 'remove_user_role', array( $remove_user_role, 'action' ) );
+        add_action( 'add_user_role', array( $add_user_role, 'action' ) );
+
+        $user->set_role( 'editor' );
+        $this->assertSame( 1, $remove_user_role->get_call_count() );
+        $this->assertSame( 1, $add_user_role->get_call_count() );
     }