Changeset 52829

Timestamp:

03/07/2022 10:50:12 PM (3 years ago)

Author:

audrasjb

Message:

Media: Allow wp_check_filetype() to support query strings in URLs.

This changeset adjusts the regex in wp_check_filetype() to support query strings in URLs.

Follow-up to [30640], [32172].

Props voldemortensen, johnbillion, layotte, dd32, atomicjack, supercleanse, spencercameron, ianmjones, audrasjb.
Fixes #30377.

Location:

trunk

Files:

• src/wp-includes/functions.php (modified) (2 diffs)
• tests/phpunit/tests/functions/wpCheckFiletype.php (added)

trunk/src/wp-includes/functions.php

@@ -2982 +2982 @@
  *
  * @since 2.0.4
- *
- * @param string   $filename File name or path.
+ * @since 6.0.0 URLs are now supported.
+ *
+ * @param string   $filename File name, path, or URL.
  * @param string[] $mimes    Optional. Array of allowed mime types keyed by their file extension regex.
  * @return array {
@@ -2998 +2999 @@
     $type = false;
     $ext  = false;
+
+    // Strip query args and fragment from filename to reveal extension.
+    $query_pos = strpos( $filename, '?' );
+
+    if ( false !== $query_pos ) {
+        $filename = substr_replace( $filename, '', $query_pos );
+    }
+
+    $filename = strip_fragment_from_url( $filename );
 
     foreach ( $mimes as $ext_preg => $mime_match ) {