Changeset 52837 for trunk/src/wp-admin/includes/image.php

Timestamp:

03/10/2022 01:08:19 PM (3 years ago)

Author:

spacedmonkey

Message:

Media: Store attachment’s file size in metadata.

Store the file size of all newly uploaded attachments, as part of the metadata stored in post meta. Storing file size means, developers will not have to resort to doing filesize function calls, that can be time consuming on assets on offloaded to services like Amazon’s S3.

This change also introduces a new helper function called, wp_filesize. This is a wrapper around the filesize php function, that adds some helpful filters and ensures the return value is an integer.

Props Cybr, Spacedmonkey, SergeyBiryukov, johnwatkins0, swissspidy, desrosj, joemcgill, azaozz, antpb, adamsilverstein, uday17035.
Fixes #49412.

File:

• trunk/src/wp-admin/includes/image.php (modified) (3 diffs)

trunk/src/wp-admin/includes/image.php

@@ -211 +211 @@
     $image_meta['original_image'] = wp_basename( $original_file );
 
+    // Add image file size.
+    $image_meta['filesize'] = wp_filesize( $new_file );
+
     return $image_meta;
 }
@@ -236 +239 @@
     // Default image meta.
     $image_meta = array(
-        'width'  => $imagesize[0],
-        'height' => $imagesize[1],
-        'file'   => _wp_relative_upload_path( $file ),
-        'sizes'  => array(),
+        'width'    => $imagesize[0],
+        'height'   => $imagesize[1],
+        'file'     => _wp_relative_upload_path( $file ),
+        'filesize' => wp_filesize( $file ),
+        'sizes'    => array(),
     );
 
@@ -630 +634 @@
     unset( $metadata['image']['data'] );
 
+    // Capture file size for cases where it has not been captured yet, such as PDFs.
+    if ( ! isset( $metadata['filesize'] ) && file_exists( $file ) ) {
+        $metadata['filesize'] = wp_filesize( $file );
+    }
+
     /**
      * Filters the generated attachment meta data.