Changeset 52841 for trunk/src/wp-admin/includes/template.php

Timestamp:

03/10/2022 06:20:33 PM (3 years ago)

Author:

SergeyBiryukov

Message:

Quick/Bulk Edit: Check the show_in_quick_edit taxonomy property when populating the data for the posts list table.

Previously, setting the show_in_quick_edit property to false removed the taxonomy from the inline edit form, but the terms were still being populated in the data for each table row via the get_inline_data() function, which only checked the $taxonomy->show_ui property.

This commit:

• Improves performance by ensuring that taxonomy terms are not unnecessarily populated for each table row when show_in_quick_edit is false.
• Properly populates the taxonomy terms when show_in_quick_edit is true and show_ui is false.

Follow-up to [31307].

Props jazbek, figureone, sabernhardt, ovidiul, webcommsat, SergeyBiryukov.
Fixes #42916, #49701.

File:

• trunk/src/wp-admin/includes/template.php (modified) (2 diffs)

trunk/src/wp-admin/includes/template.php

@@ -345 +345 @@
         $taxonomy = get_taxonomy( $taxonomy_name );
 
-        if ( $taxonomy->hierarchical && $taxonomy->show_ui ) {
+        if ( ! $taxonomy->show_in_quick_edit ) {
+            continue;
+        }
+
+        if ( $taxonomy->hierarchical ) {
 
             $terms = get_object_term_cache( $post->ID, $taxonomy_name );
@@ -356 +360 @@
             echo '<div class="post_category" id="' . $taxonomy_name . '_' . $post->ID . '">' . implode( ',', $term_ids ) . '</div>';
 
-        } elseif ( $taxonomy->show_ui ) {
+        } else {
 
             $terms_to_edit = get_terms_to_edit( $post->ID, $taxonomy_name );