Changeset 52921 for trunk/tests/phpunit/tests/term/splitSharedTerm.php

Timestamp:

03/11/2022 11:05:02 AM (4 years ago)

Author:

spacedmonkey

Message:

Taxonomy: Use get_terms instead of a database lookup in term_exists().

Replace raw SQL queries to the terms table, with a call to the get_terms function. Using get_terms means that term_exists is now cached. For developers using term_exists where cache invalidation is disabled, such as importing, a workaround was added to ensure that queries are uncached.

Props Spacedmonkey, boonebgorges, flixos90, peterwilsoncc.
Fixes #36949.

File:

• trunk/tests/phpunit/tests/term/splitSharedTerm.php (modified) (6 diffs)

trunk/tests/phpunit/tests/term/splitSharedTerm.php

@@ -55 +55 @@
                         array( '%d' )
                 );
+                clean_term_cache( $t1['term_id'], 'category' );
 
                 $t2_child = wp_insert_term(
@@ -152 +153 @@
                         array( '%d' )
                 );
+                clean_term_cache( $t1['term_id'], 'category' );
                 $th = _get_term_hierarchy( 'wptests_tax_4' );
 
@@ -180 +182 @@
                         array( '%d' )
                 );
+                clean_term_cache( $t1['term_id'], 'category' );
 
                 $this->assertSame( $t1['term_id'], get_option( 'default_category', -1 ) );
@@ -208 +211 @@
                         array( '%d' )
                 );
+                clean_term_cache( $t1['term_id'], 'category' );
 
                 $menu_id       = wp_create_nav_menu( 'Nav Menu Bar' );
@@ -246 +250 @@
                         array( 'term_taxonomy_id' => $nav_term->term_taxonomy_id )
                 );
+                clean_term_cache( $shared_term_id, 'category' );
 
                 set_theme_mod( 'nav_menu_locations', array( 'foo' => $shared_term_id ) );
@@ -275 +280 @@
                         array( 'term_taxonomy_id' => $nav_term->term_taxonomy_id )
                 );
+                clean_term_cache( $shared_term_id, 'category' );
 
                 $t1            = wp_insert_term( 'Random term', 'category' );