Changeset 52921 for trunk/tests/phpunit/tests/term/termExists.php

Timestamp:

03/11/2022 11:05:02 AM (4 years ago)

Author:

spacedmonkey

Message:

Taxonomy: Use get_terms instead of a database lookup in term_exists().

Replace raw SQL queries to the terms table, with a call to the get_terms function. Using get_terms means that term_exists is now cached. For developers using term_exists where cache invalidation is disabled, such as importing, a workaround was added to ensure that queries are uncached.

Props Spacedmonkey, boonebgorges, flixos90, peterwilsoncc.
Fixes #36949.

File:

• trunk/tests/phpunit/tests/term/termExists.php (modified) (1 diff)

trunk/tests/phpunit/tests/term/termExists.php

@@ -272 +272 @@
         }
 
+        /**
+         * @ticket 36949
+         * @covers ::term_exists()
+         */
+        public function test_term_lookup_by_id_and_update() {
+                register_taxonomy( 'wptests_tax', 'post' );
+
+                $slug = __FUNCTION__;
+                $t    = self::factory()->term->create(
+                        array(
+                                'slug'     => $slug,
+                                'taxonomy' => 'wptests_tax',
+                        )
+                );
+                $this->assertEquals( $t, term_exists( $t ) );
+                $this->assertTrue( wp_delete_term( $t, 'wptests_tax' ) );
+                $this->assertNull( term_exists( $t ) );
+
+                // Clean up.
+                _unregister_taxonomy( 'wptests_tax' );
+        }
+
+        /**
+         * @ticket 36949
+         * @covers ::term_exists()
+         */
+        public function test_term_lookup_by_slug_and_update() {
+                register_taxonomy( 'wptests_tax', 'post' );
+
+                $slug = __FUNCTION__;
+                $t    = self::factory()->term->create(
+                        array(
+                                'slug'     => $slug,
+                                'taxonomy' => 'wptests_tax',
+                        )
+                );
+                $this->assertEquals( $t, term_exists( $slug ) );
+                $this->assertTrue( wp_delete_term( $t, 'wptests_tax' ) );
+                $this->assertNull( term_exists( $slug ) );
+
+                // Clean up.
+                _unregister_taxonomy( 'wptests_tax' );
+        }
+
+        /**
+         * @ticket 36949
+         * @covers ::term_exists()
+         */
+        public function test_term_exists_caching() {
+                global $wpdb;
+                register_taxonomy( 'wptests_tax', 'post' );
+
+                $slug = __FUNCTION__;
+                $t    = self::factory()->term->create(
+                        array(
+                                'slug'     => $slug,
+                                'taxonomy' => 'wptests_tax',
+                        )
+                );
+                $this->assertEquals( $t, term_exists( $slug ) );
+                $num_queries = $wpdb->num_queries;
+                $this->assertEquals( $t, term_exists( $slug ) );
+                $this->assertSame( $num_queries, $wpdb->num_queries );
+
+                $this->assertTrue( wp_delete_term( $t, 'wptests_tax' ) );
+                $num_queries = $wpdb->num_queries;
+                $this->assertNull( term_exists( $slug ) );
+                $this->assertSame( $num_queries + 2, $wpdb->num_queries );
+
+                // Clean up.
+                _unregister_taxonomy( 'wptests_tax' );
+        }
+
+        /**
+         * @ticket 36949
+         * @covers ::term_exists()
+         */
+        public function test_term_exists_caching_suspend_cache_invalidation() {
+                global $wpdb;
+                register_taxonomy( 'wptests_tax', 'post' );
+
+                wp_suspend_cache_invalidation( true );
+                $slug = __FUNCTION__;
+                $t    = self::factory()->term->create(
+                        array(
+                                'slug'     => $slug,
+                                'taxonomy' => 'wptests_tax',
+                        )
+                );
+
+                $this->assertEquals( $t, term_exists( $slug ) );
+                $num_queries = $wpdb->num_queries;
+                $this->assertEquals( $t, term_exists( $slug ) );
+                $this->assertSame( $num_queries + 1, $wpdb->num_queries );
+                wp_suspend_cache_invalidation( false );
+
+                // Clean up.
+                _unregister_taxonomy( 'wptests_tax' );
+        }
+
+        /**
+         * @ticket 36949
+         * @covers ::term_exists()
+         */
+        public function test_term_exists_caching_by_int_suspend_cache_invalidation() {
+                register_taxonomy( 'wptests_tax', 'post' );
+
+                $slug = __FUNCTION__;
+                $t    = self::factory()->term->create(
+                        array(
+                                'slug'     => $slug,
+                                'taxonomy' => 'wptests_tax',
+                        )
+                );
+
+                // Warm cache in get_term() via term_exists().
+                term_exists( $t );
+                wp_suspend_cache_invalidation( true );
+                wp_delete_term( $t, 'wptests_tax' );
+                $this->assertNull( term_exists( $t ) );
+
+                // Reneable cache invalidation.
+                wp_suspend_cache_invalidation( false );
+                _unregister_taxonomy( 'wptests_tax' );
+        }
+
         public function test_term_exists_unknown() {
                 $this->assertNull( term_exists( rand_str() ) );