Context Navigation

← Previous Change
Next Change →

functions.php

Timestamp:

03/14/2022 04:30:35 PM (4 years ago)

Author:

hellofromTonya

Message:

Media: Relocate wp_filesize() function for use in frontend and backend.

A new function wp_filesize() was added with [52837]. The function lived in the wp-admin/includes/file.php file. However, this admin specific function is not loaded into memory when hitting media/edit endpoint. The result was a 500 Internal Server Error. Why? The function is invoked with that endpoint, but the function does not exist in memory.

This commit relocates the new function to the wp-includes/functions.php file. In doing so, the function is available for both the frontend and backend.

Follow-up to [52837].

Props talldanwp, spacedmonkey, costdev, antonvlasenko.
Fixes #55367.

File:

: 1 edited

trunk/tests/phpunit/tests/functions.php (modified) (1 diff)

Legend:

: Unmodified
: Added
: Removed

trunk/tests/phpunit/tests/functions.php

-              r52328
+              r52932
                 $this->assertFalse( wp_get_default_extension_for_mime_type( null ), 'false not returned when null as mime type supplied' );
+        }
+        /**
+         * @ticket 49412
+         * @covers ::wp_filesize
+         */
+        function test_wp_filesize_with_nonexistent_file() {
+                $file = 'nonexistent/file.jpg';
+                $this->assertEquals( 0, wp_filesize( $file ) );
+        }
+        /**
+         * @ticket 49412
+         * @covers ::wp_filesize
+         */
+        function test_wp_filesize() {
+                $file = DIR_TESTDATA . '/images/test-image-upside-down.jpg';
+                $this->assertEquals( filesize( $file ), wp_filesize( $file ) );
+                $filter = function() {
+                        return 999;
+                };
+                add_filter( 'wp_filesize', $filter );
+                $this->assertEquals( 999, wp_filesize( $file ) );
+                $pre_filter = function() {
+                        return 111;
+                };
+                add_filter( 'pre_wp_filesize', $pre_filter );
+                $this->assertEquals( 111, wp_filesize( $file ) );
+        }
+}

Note: See TracChangeset for help on using the changeset viewer.

Make WordPress Core

Context Navigation

Changeset 52932 for trunk/tests/phpunit/tests/functions.php

Legend:

trunk/tests/phpunit/tests/functions.php

Download in other formats: