Changeset 52947 for trunk/src/wp-admin/themes.php

Timestamp:

03/17/2022 10:19:58 PM (3 years ago)

Author:

audrasjb

Message:

Themes: Add version to theme screenshot URL for better browser cache handling.

This change appends the theme version number to the URL of screenshots that appear in various place of the WordPress Admin. As a result, browsers will be able to refresh the screenshot as needed when the theme is updated.

Props codente, desrosj, audrasjb, SergeyBiryukov.
Fixes #53370.

File:

• trunk/src/wp-admin/themes.php (modified) (3 diffs)

trunk/src/wp-admin/themes.php

@@ -389 +389 @@
     <?php if ( ! empty( $theme['screenshot'][0] ) ) { ?>
         <div class="theme-screenshot">
-            <img src="<?php echo esc_attr( $theme['screenshot'][0] ); ?>" alt="" />
+            <img src="<?php echo esc_attr( $theme['screenshot'][0] . '?ver=' . $theme['version'] ); ?>" alt="" />
         </div>
     <?php } else { ?>
@@ -740 +740 @@
     <# if ( data.screenshot[0] ) { #>
         <div class="theme-screenshot">
-            <img src="{{ data.screenshot[0] }}" alt="" />
+            <img src="{{ data.screenshot[0] }}?ver={{ data.version }}" alt="" />
         </div>
     <# } else { #>
@@ -948 +948 @@
             <div class="theme-screenshots">
             <# if ( data.screenshot[0] ) { #>
-                <div class="screenshot"><img src="{{ data.screenshot[0] }}" alt="" /></div>
+                <div class="screenshot"><img src="{{ data.screenshot[0] }}?ver={{ data.version }}" alt="" /></div>
             <# } else { #>
                 <div class="screenshot blank"></div>