Changeset 52951

Timestamp:

03/18/2022 06:12:47 PM (5 years ago)

Author:

davidbaumwald

Message:

Comments: Disable "close on escape" for inline replies when using an IME.

When using an Input Method Editor(IME), pressing escape to perform actions in the IME is common. However, if this was done while replying to a comment, the "close on escape" feature was also triggered which cleared the current textarea and closed it.

This change checks if an IME is in use by binding the compositionstart event to the reply text box and setting a flag if it's triggered. The "close on escape" feature will now only be triggered if this new flag is not set after typing a reply.

Props BettyJJ, sabernhardt, alexstine, konradyoast, audrasjb, rafiahmedd, afercia.
Fixes #54548.

File:

• trunk/src/js/_enqueues/admin/edit-comments.js (modified) (2 diffs)

trunk/src/js/_enqueues/admin/edit-comments.js

@@ -1020 +1020 @@
 
                 setTimeout(function() {
-                        var rtop, rbottom, scrollTop, vp, scrollBottom;
+                        var rtop, rbottom, scrollTop, vp, scrollBottom,
+                                isComposing = false;
 
                         rtop = $('#replyrow').offset().top;
@@ -1033 +1034 @@
                                 window.scroll(0, rtop - 35);
 
-                        $('#replycontent').trigger( 'focus' ).on( 'keyup', function(e){
-                                if ( e.which == 27 )
-                                        commentReply.revert(); // Close on Escape.
-                        });
+                        $( '#replycontent' )
+                                .trigger( 'focus' )
+                                .on( 'keyup', function( e ) {
+                                        // Close on Escape except when Input Method Editors (IMEs) are in use.
+                                        if ( e.which === 27 && ! isComposing ) {
+                                                commentReply.revert();
+                                        }
+                                } )
+                                .on( 'compositionstart', function() {
+                                        isComposing = true;
+                                } );
                 }, 600);