Changeset 52952 for trunk/tests/phpunit/tests/filters.php

Timestamp:

03/18/2022 06:21:40 PM (3 years ago)

Author:

johnbillion

Message:

Plugins: Convert apply_filters() into a proper variadic function.

This makes its signature more correct by implementing the spread operator, and adjusts the internal logic correspondingly without affecting performance.

Props jrf, SergeyBiryukov, davidbaumwald, mauriac, johnbillion

Fixes #53218

File:

• trunk/tests/phpunit/tests/filters.php (modified) (1 diff)

trunk/tests/phpunit/tests/filters.php

@@ -217 +217 @@
 
     /**
+     * @ticket 53218
+     */
+    public function test_filter_with_ref_value() {
+        $obj = new stdClass();
+        $ref = &$obj;
+        $a   = new MockAction();
+        $tag = __FUNCTION__;
+
+        add_action( $tag, array( $a, 'filter' ) );
+
+        $filtered = apply_filters( $tag, $ref );
+
+        $args = $a->get_args();
+        $this->assertSame( $args[0][0], $obj );
+        $this->assertSame( $filtered, $obj );
+        // Just in case we don't trust assertSame().
+        $obj->foo = true;
+        $this->assertNotEmpty( $args[0][0]->foo );
+        $this->assertNotEmpty( $filtered->foo );
+    }
+
+    /**
+     * @ticket 53218
+     */
+    public function test_filter_with_ref_argument() {
+        $obj = new stdClass();
+        $ref = &$obj;
+        $a   = new MockAction();
+        $tag = __FUNCTION__;
+        $val = 'Hello';
+
+        add_action( $tag, array( $a, 'filter' ), 10, 2 );
+
+        apply_filters( $tag, $val, $ref );
+
+        $args = $a->get_args();
+        $this->assertSame( $args[0][1], $obj );
+        // Just in case we don't trust assertSame().
+        $obj->foo = true;
+        $this->assertNotEmpty( $args[0][1]->foo );
+    }
+
+    /**
      * @ticket 9886
      */