Changeset 52954

Timestamp:

03/18/2022 08:42:43 PM (3 years ago)

Author:

davidbaumwald

Message:

Users: Check maximum length of user_nicename after filters are applied.

Similar to other checks on user_login and user_url, this change moves the maximum length check on user_nicename after the pre_user_nicename filter has been applied, to account for any changes to the value prior to saving.

Props SergeyBiryukov, ravipatel, muhammadfaizanhaidar, mukesh27, csesumonpro, azouamauriac.
Fixes #54987.

File:

• trunk/src/wp-includes/user.php (modified) (2 diffs)

trunk/src/wp-includes/user.php

@@ -1978 +1978 @@
     if ( ! empty( $userdata['user_nicename'] ) ) {
         $user_nicename = sanitize_user( $userdata['user_nicename'], true );
-        if ( mb_strlen( $user_nicename ) > 50 ) {
-            return new WP_Error( 'user_nicename_too_long', __( 'Nicename may not be longer than 50 characters.' ) );
-        }
     } else {
         $user_nicename = mb_substr( $user_login, 0, 50 );
@@ -1995 +1992 @@
      */
     $user_nicename = apply_filters( 'pre_user_nicename', $user_nicename );
+
+    if ( mb_strlen( $user_nicename ) > 50 ) {
+        return new WP_Error( 'user_nicename_too_long', __( 'Nicename may not be longer than 50 characters.' ) );
+    }
 
     $user_nicename_check = $wpdb->get_var( $wpdb->prepare( "SELECT ID FROM $wpdb->users WHERE user_nicename = %s AND user_login != %s LIMIT 1", $user_nicename, $user_login ) );