Changeset 52957

Timestamp:

03/19/2022 08:30:01 PM (3 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use esc_url() instead of esc_attr() for some URLs.

Follow-up to [2063], [2182], [4656], [6952], [9098], [11109], [11204], [17887], [22505],

Props kebbet.
See #54728.

Location:

trunk/src

Files:

• wp-admin/includes/class-custom-image-header.php (modified) (1 diff)
• wp-admin/includes/class-wp-comments-list-table.php (modified) (1 diff)
• wp-admin/includes/dashboard.php (modified) (1 diff)
• wp-includes/media.php (modified) (1 diff)
• wp-links-opml.php (modified) (1 diff)

trunk/src/wp-admin/includes/class-custom-image-header.php

@@ -652 +652 @@
     </p>
             <?php
-                $modal_update_href = esc_url(
-                    add_query_arg(
-                        array(
-                            'page' => 'custom-header',
-                            'step' => 2,
-                            '_wpnonce-custom-header-upload' => wp_create_nonce( 'custom-header-upload' ),
-                        ),
-                        admin_url( 'themes.php' )
-                    )
-                );
+            $modal_update_href = add_query_arg(
+                array(
+                    'page'                          => 'custom-header',
+                    'step'                          => 2,
+                    '_wpnonce-custom-header-upload' => wp_create_nonce( 'custom-header-upload' ),
+                ),
+                admin_url( 'themes.php' )
+            );
             ?>
     <p>
         <label for="choose-from-library-link"><?php _e( 'Or choose an image from your media library:' ); ?></label><br />
         <button id="choose-from-library-link" class="button"
-            data-update-link="<?php echo esc_attr( $modal_update_href ); ?>"
+            data-update-link="<?php echo esc_url( $modal_update_href ); ?>"
             data-choose="<?php esc_attr_e( 'Choose a Custom Header' ); ?>"
             data-update="<?php esc_attr_e( 'Set as header' ); ?>"><?php _e( 'Choose Image' ); ?></button>

trunk/src/wp-admin/includes/class-wp-comments-list-table.php

@@ -920 +920 @@
             <div class="author-email"><?php echo esc_attr( $comment->comment_author_email ); ?></div>
             <div class="author"><?php echo esc_attr( $comment->comment_author ); ?></div>
-            <div class="author-url"><?php echo esc_attr( $comment->comment_author_url ); ?></div>
+            <div class="author-url"><?php echo esc_url( $comment->comment_author_url ); ?></div>
             <div class="comment_status"><?php echo $comment->comment_approved; ?></div>
         </div>

trunk/src/wp-admin/includes/dashboard.php

@@ -1691 +1691 @@
             $img_src = ( is_ssl() && ! empty( $response['img_src_ssl'] ) ) ? $response['img_src_ssl'] : $response['img_src'];
 
-            $notice           .= '<div class="alignright browser-icon"><img src="' . esc_attr( $img_src ) . '" alt="" /></div>';
+            $notice           .= '<div class="alignright browser-icon"><img src="' . esc_url( $img_src ) . '" alt="" /></div>';
             $browser_nag_class = ' has-browser-icon';
         }

trunk/src/wp-includes/media.php

@@ -394 +394 @@
     $class = apply_filters( 'get_image_tag_class', $class, $id, $align, $size );
 
-    $html = '<img src="' . esc_attr( $img_src ) . '" alt="' . esc_attr( $alt ) . '" ' . $title . $hwstring . 'class="' . $class . '" />';
+    $html = '<img src="' . esc_url( $img_src ) . '" alt="' . esc_attr( $alt ) . '" ' . $title . $hwstring . 'class="' . $class . '" />';
 
     /**

trunk/src/wp-links-opml.php

@@ -81 +81 @@
         $title = apply_filters( 'link_title', $bookmark->link_name );
         ?>
-<outline text="<?php echo esc_attr( $title ); ?>" type="link" xmlUrl="<?php echo esc_attr( $bookmark->link_rss ); ?>" htmlUrl="<?php echo esc_attr( $bookmark->link_url ); ?>" updated="
+<outline text="<?php echo esc_attr( $title ); ?>" type="link" xmlUrl="<?php echo esc_url( $bookmark->link_rss ); ?>" htmlUrl="<?php echo esc_url( $bookmark->link_url ); ?>" updated="
                             <?php
                             if ( '0000-00-00 00:00:00' !== $bookmark->link_updated ) {