Changeset 52957 for trunk/src/wp-admin/includes/class-custom-image-header.php

Timestamp:

03/19/2022 08:30:01 PM (3 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use esc_url() instead of esc_attr() for some URLs.

Follow-up to [2063], [2182], [4656], [6952], [9098], [11109], [11204], [17887], [22505],

Props kebbet.
See #54728.

File:

• trunk/src/wp-admin/includes/class-custom-image-header.php (modified) (1 diff)

trunk/src/wp-admin/includes/class-custom-image-header.php

@@ -652 +652 @@
     </p>
             <?php
-                $modal_update_href = esc_url(
-                    add_query_arg(
-                        array(
-                            'page' => 'custom-header',
-                            'step' => 2,
-                            '_wpnonce-custom-header-upload' => wp_create_nonce( 'custom-header-upload' ),
-                        ),
-                        admin_url( 'themes.php' )
-                    )
-                );
+            $modal_update_href = add_query_arg(
+                array(
+                    'page'                          => 'custom-header',
+                    'step'                          => 2,
+                    '_wpnonce-custom-header-upload' => wp_create_nonce( 'custom-header-upload' ),
+                ),
+                admin_url( 'themes.php' )
+            );
             ?>
     <p>
         <label for="choose-from-library-link"><?php _e( 'Or choose an image from your media library:' ); ?></label><br />
         <button id="choose-from-library-link" class="button"
-            data-update-link="<?php echo esc_attr( $modal_update_href ); ?>"
+            data-update-link="<?php echo esc_url( $modal_update_href ); ?>"
             data-choose="<?php esc_attr_e( 'Choose a Custom Header' ); ?>"
             data-update="<?php esc_attr_e( 'Set as header' ); ?>"><?php _e( 'Choose Image' ); ?></button>