Changeset 52964

Timestamp:

03/20/2022 04:01:01 PM (3 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Rename the $strResponse variable to $response in WP_Http_Streams::request().

This fixes a Variable "$strResponse" is not in valid snake_case format WPCS warning.

For consistency, this commit also renames the WP_Http::processResponse() argument to $response.

Follow-up to [8516], [51825], [51929], [51940], [52025], [52960], [52961], [52962], [52963].

Props azouamauriac.
See #54728.

Location:

trunk/src/wp-includes

Files:

• class-wp-http-streams.php (modified) (4 diffs)
• class-wp-http.php (modified) (2 diffs)

trunk/src/wp-includes/class-wp-http-streams.php

@@ -264 +264 @@
         }
 
-        $strResponse  = '';
+        $response     = '';
         $body_started = false;
         $keep_reading = true;
@@ -298 +298 @@
                 $block = fread( $handle, $block_size );
                 if ( ! $body_started ) {
-                    $strResponse .= $block;
-                    if ( strpos( $strResponse, "\r\n\r\n" ) ) {
-                        $processed_response = WP_Http::processResponse( $strResponse );
+                    $response .= $block;
+                    if ( strpos( $response, "\r\n\r\n" ) ) {
+                        $processed_response = WP_Http::processResponse( $response );
                         $body_started       = true;
                         $block              = $processed_response['body'];
-                        unset( $strResponse );
+                        unset( $response );
                         $processed_response['body'] = '';
                     }
@@ -339 +339 @@
 
             while ( ! feof( $handle ) && $keep_reading ) {
-                $block        = fread( $handle, $block_size );
-                $strResponse .= $block;
-
-                if ( ! $body_started && strpos( $strResponse, "\r\n\r\n" ) ) {
-                    $header_length = strpos( $strResponse, "\r\n\r\n" ) + 4;
+                $block     = fread( $handle, $block_size );
+                $response .= $block;
+
+                if ( ! $body_started && strpos( $response, "\r\n\r\n" ) ) {
+                    $header_length = strpos( $response, "\r\n\r\n" ) + 4;
                     $body_started  = true;
                 }
@@ -350 +350 @@
                     ! $body_started
                     || ! isset( $parsed_args['limit_response_size'] )
-                    || strlen( $strResponse ) < ( $header_length + $parsed_args['limit_response_size'] )
-                );
-            }
-
-            $processed_response = WP_Http::processResponse( $strResponse );
-            unset( $strResponse );
+                    || strlen( $response ) < ( $header_length + $parsed_args['limit_response_size'] )
+                );
+            }
+
+            $processed_response = WP_Http::processResponse( $response );
+            unset( $response );
 
         }

trunk/src/wp-includes/class-wp-http.php

@@ -656 +656 @@
      * @since 2.7.0
      *
-     * @param string $str_response The full response string.
+     * @param string $response The full response string.
      * @return array {
      *     Array with response headers and body.
@@ -664 +664 @@
      * }
      */
-    public static function processResponse( $str_response ) { // phpcs:ignore WordPress.NamingConventions.ValidFunctionName.MethodNameInvalid
-        $response = explode( "\r\n\r\n", $str_response, 2 );
+    public static function processResponse( $response ) { // phpcs:ignore WordPress.NamingConventions.ValidFunctionName.MethodNameInvalid
+        $response = explode( "\r\n\r\n", $response, 2 );
 
         return array(