Changeset 52982

Timestamp:

03/23/2022 10:37:11 AM (4 years ago)

Author:

spacedmonkey

Message:

Query: Improved sticky post query

Ensure that the parameters update_post_meta_cache, update_post_term_cache, cache_results, suppress_filters and
lazy_load_term_meta that are passed to WP_Query, are also passed down to the secondary query used to get sticky
posts.

Props Spacedmonkey, peterwilsoncc, rehanali, uday17035.
Fixes #36907.

Location:

trunk

Files:

• src/wp-includes/class-wp-query.php (modified) (1 diff)
• tests/phpunit/tests/query/stickies.php (modified) (2 diffs)

trunk/src/wp-includes/class-wp-query.php

@@ -3261 +3261 @@
                                 $stickies = get_posts(
                                         array(
-                                                'post__in'    => $sticky_posts,
-                                                'post_type'   => $post_type,
-                                                'post_status' => 'publish',
-                                                'nopaging'    => true,
+                                                'cache_results'          => $q['cache_results'],
+                                                'lazy_load_term_meta'    => $q['lazy_load_term_meta'],
+                                                'post__in'               => $sticky_posts,
+                                                'post_type'              => $post_type,
+                                                'post_status'            => 'publish',
+                                                'suppress_filters'       => $q['suppress_filters'],
+                                                'update_post_meta_cache' => $q['update_post_meta_cache'],
+                                                'update_post_term_cache' => $q['update_post_term_cache'],
                                         )
                                 );

trunk/tests/phpunit/tests/query/stickies.php

@@ -5 +5 @@
  *
  * @group query
+ * @covers WP_Query::get_posts
  */
 class Tests_Query_Stickies extends WP_UnitTestCase {
@@ -105 +106 @@
                 $q->set( 'post__not_in', array( self::$posts[8] ) );
         }
+
+        /**
+         * @ticket 36907
+         */
+        public function test_stickies_nest_query() {
+                $filter = new MockAction();
+                add_filter( 'posts_pre_query', array( $filter, 'filter' ), 10, 2 );
+                $this->go_to( '/' );
+                $filter_args       = $filter->get_args();
+                $query_vars        = $filter_args[0][1]->query_vars;
+                $sticky_query_vars = $filter_args[1][1]->query_vars;
+
+                $this->assertNotEmpty( $sticky_query_vars['posts_per_page'] );
+                $this->assertSame( $query_vars['suppress_filters'], $sticky_query_vars['suppress_filters'] );
+                $this->assertSame( $query_vars['update_post_meta_cache'], $sticky_query_vars['update_post_meta_cache'] );
+                $this->assertSame( $query_vars['update_post_term_cache'], $sticky_query_vars['update_post_term_cache'] );
+                $this->assertSame( $query_vars['lazy_load_term_meta'], $sticky_query_vars['lazy_load_term_meta'] );
+                $this->assertSame( $query_vars['cache_results'], $sticky_query_vars['cache_results'] );
+                $this->assertTrue( $sticky_query_vars['ignore_sticky_posts'] );
+                $this->assertTrue( $sticky_query_vars['no_found_rows'] );
+        }
 }