Changeset 52990

Timestamp:

03/25/2022 09:54:52 AM (5 years ago)

Author:

spacedmonkey

Message:

Query: Ensure that sticky post query returns all sticky posts.

Ensure that the posts_per_page parameter submit to sticky post query matches the number of sticky posts requested.

Follow-up to [52982]

Props Spacedmonkey, peterwilsoncc.
See #36907.

Location:

trunk

Files:

• src/wp-includes/class-wp-query.php (modified) (1 diff)
• tests/phpunit/tests/query/stickies.php (modified) (1 diff)

trunk/src/wp-includes/class-wp-query.php

@@ -3264 +3264 @@
                                                 'post_type'              => $post_type,
                                                 'post_status'            => 'publish',
+                                                'posts_per_page'         => count( $sticky_posts ),
                                                 'suppress_filters'       => $q['suppress_filters'],
                                                 'cache_results'          => $q['cache_results'],

trunk/tests/phpunit/tests/query/stickies.php

@@ -127 +127 @@
                 $this->assertTrue( $sticky_query_vars['no_found_rows'] );
         }
+
+        /**
+         * @ticket 36907
+         */
+        public function test_stickies_should_limit_query() {
+                $sticky_count = 6;
+                $post_date    = gmdate( 'Y-m-d H:i:s', time() - 10000 );
+                $post_ids     = self::factory()->post->create_many( $sticky_count, array( 'post_date' => $post_date ) );
+                add_filter(
+                        'pre_option_sticky_posts',
+                        function () use ( $post_ids ) {
+                                return $post_ids;
+                        }
+                );
+
+                $filter = new MockAction();
+                add_filter( 'posts_pre_query', array( $filter, 'filter' ), 10, 2 );
+                $this->go_to( '/' );
+                $filter_args       = $filter->get_args();
+                $sticky_query_vars = $filter_args[1][1]->query_vars;
+
+                $this->assertSame( $sticky_query_vars['posts_per_page'], $sticky_count );
+        }
 }