Changeset 53010

Timestamp:

03/29/2022 11:05:26 AM (18 months ago)

Author:

spacedmonkey

Message:

Menus: Convert wp_get_nav_menu_items function to use a taxonomy query.

Change the wp_get_nav_menu_items function to replace the call to get_objects_in_term with a simple taxonomy query. This change improves performance as it results in one fewer query to retrieve menu items from the
database.

Props Spacedmonkey, peterwilsoncc.
Fixes #55372.

File:

• trunk/src/wp-includes/nav-menu.php (modified) (2 diffs)

trunk/src/wp-includes/nav-menu.php

@@ -694 +694 @@
     static $fetched = array();
 
-    $items = get_objects_in_term( $menu->term_id, 'nav_menu' );
-    if ( is_wp_error( $items ) ) {
+    if ( ! taxonomy_exists( 'nav_menu' ) ) {
         return false;
     }
 
-    $defaults        = array(
+    $defaults = array(
         'order'       => 'ASC',
         'orderby'     => 'menu_order',
@@ -707 +706 @@
         'output_key'  => 'menu_order',
         'nopaging'    => true,
+        'tax_query'   => array(
+            array(
+                'taxonomy' => 'nav_menu',
+                'field'    => 'term_taxonomy_id',
+                'terms'    => $menu->term_taxonomy_id,
+            ),
+        ),
     );
-    $args            = wp_parse_args( $args, $defaults );
-    $args['include'] = $items;
-
-    if ( ! empty( $items ) ) {
+    $args     = wp_parse_args( $args, $defaults );
+    if ( $menu->count > 0 ) {
         $items = get_posts( $args );
     } else {