Changeset 53027 for trunk/src/wp-admin/includes/ajax-actions.php

Timestamp:

03/29/2022 09:46:09 PM (2 years ago)

Author:

joedolson

Message:

Media: Preserve attachment properties on cropping custom logo.

Migrate the alternative text, title, description, and caption of an image over to the cropped copy of the image after cropping. Ensure that characteristics added to an image prior to cropping are not lost.

Props flixos90, Clorith, afercia, antonvlasenko, ironprogrammer, hellofromTonya.
Fixes #37750.

File:

• trunk/src/wp-admin/includes/ajax-actions.php (modified) (1 diff)

trunk/src/wp-admin/includes/ajax-actions.php

@@ -3971 +3971 @@
             $cropped = apply_filters( 'wp_create_file_in_uploads', $cropped, $attachment_id ); // For replication.
 
-            $parent_url = wp_get_attachment_url( $attachment_id );
-            $url        = str_replace( wp_basename( $parent_url ), wp_basename( $cropped ), $parent_url );
+            $parent_url      = wp_get_attachment_url( $attachment_id );
+            $parent_basename = wp_basename( $parent_url );
+            $url             = str_replace( $parent_basename, wp_basename( $cropped ), $parent_url );
 
             $size       = wp_getimagesize( $cropped );
             $image_type = ( $size ) ? $size['mime'] : 'image/jpeg';
 
+            // Get the original image's post to pre-populate the cropped image.
+            $original_attachment      = get_post( $attachment_id );
+            $sanitized_post_title     = sanitize_file_name( $original_attachment->post_title );
+            $use_original_title       = (
+                ( '' !== trim( $original_attachment->post_title ) ) &&
+                /*
+                 * Check if the original image has a title other than the "filename" default,
+                 * meaning the image had a title when originally uploaded or its title was edited.
+                 */
+                ( $parent_basename !== $sanitized_post_title ) &&
+                ( pathinfo( $parent_basename, PATHINFO_FILENAME ) !== $sanitized_post_title )
+            );
+            $use_original_description = ( '' !== trim( $original_attachment->post_content ) );
+
             $object = array(
-                'post_title'     => wp_basename( $cropped ),
-                'post_content'   => $url,
+                'post_title'     => $use_original_title ? $original_attachment->post_title : wp_basename( $cropped ),
+                'post_content'   => $use_original_description ? $original_attachment->post_content : $url,
                 'post_mime_type' => $image_type,
                 'guid'           => $url,
                 'context'        => $context,
             );
+
+            // Copy the image caption attribute (post_excerpt field) from the original image.
+            if ( '' !== trim( $original_attachment->post_excerpt ) ) {
+                $object['post_excerpt'] = $original_attachment->post_excerpt;
+            }
+
+            // Copy the image alt text attribute from the original image.
+            if ( '' !== trim( $original_attachment->_wp_attachment_image_alt ) ) {
+                $object['meta_input'] = array(
+                    '_wp_attachment_image_alt' => wp_slash( $original_attachment->_wp_attachment_image_alt ),
+                );
+            }
 
             $attachment_id = wp_insert_attachment( $object, $cropped );