Changeset 53036 for trunk/tests/phpunit/tests/comment/getCommentCount.php

Timestamp:

03/31/2022 09:07:02 AM (3 years ago)

Author:

spacedmonkey

Message:

Comments: Improve performance of the wp_count_comments function.

Improve performance of the wp_count_comments function by replacing a complex query with multiple calls to the get_comments function. Passing the count parameter to the get_comments function results in a simple
count query that returns quickly. Using get_comments also means that query is cached and run through filters.

Props FolioVision, markjaquith, nacin, ryan, coffee2code, wonderboymusic, ComputerGuru, jb510, SergeyBiryukov, Znuff, Rahe, uday17035, spacedmonkey, peterwilsoncc.
Fixes #19901.

File:

• trunk/tests/phpunit/tests/comment/getCommentCount.php (modified) (2 diffs)

trunk/tests/phpunit/tests/comment/getCommentCount.php

@@ -12 +12 @@
         $this->assertSame( 0, $count['post-trashed'] );
         $this->assertSame( 0, $count['total_comments'] );
+        $this->assertSame( 0, $count['all'] );
     }
 
@@ -98 +99 @@
         $this->assertSame( 0, $count['total_comments'] );
     }
+
+    /**
+     * @ticket 19901
+     *
+     * @covers ::get_comment_count
+     */
+    public function test_get_comment_count_validate_cache_comment_deleted() {
+
+        $comment_id = self::factory()->comment->create();
+
+        $count = get_comment_count();
+
+        $this->assertSame( 1, $count['total_comments'] );
+
+        wp_delete_comment( $comment_id, true );
+
+        $count = get_comment_count();
+
+        $this->assertSame( 0, $count['total_comments'] );
+    }
+
+    /**
+     * @ticket 19901
+     *
+     * @covers ::get_comment_count
+     */
+    public function test_get_comment_count_validate_cache_post_deleted() {
+
+        $post_id = self::factory()->post->create();
+
+        $comment_id = self::factory()->comment->create(
+            array(
+                'comment_post_ID' => $post_id,
+            )
+        );
+
+        $count = get_comment_count( $post_id );
+
+        $this->assertSame( 1, $count['total_comments'] );
+
+        wp_delete_post( $post_id, true );
+
+        $count = get_comment_count( $post_id );
+
+        $this->assertSame( 0, $count['total_comments'] );
+    }
+
+    /**
+     * @ticket 19901
+     *
+     * @covers ::get_comment_count
+     */
+    public function test_get_comment_count_validate_cache_comment_status() {
+        $comment_id = self::factory()->comment->create();
+
+        $count = get_comment_count();
+
+        $this->assertSame( 1, $count['approved'] );
+        $this->assertSame( 0, $count['trash'] );
+        $this->assertSame( 1, $count['total_comments'] );
+
+        wp_set_comment_status( $comment_id, 'trash' );
+
+        $count = get_comment_count();
+
+        $this->assertSame( 0, $count['approved'] );
+        $this->assertSame( 1, $count['trash'] );
+        $this->assertSame( 0, $count['total_comments'] );
+    }
 }