Changeset 53039

Timestamp:

03/31/2022 03:19:10 PM (2 years ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Rename parameters that use reserved keywords in wp-admin/includes/class-wp-list-table.php.

While using reserved PHP keywords as parameter name labels is allowed, in the context of function calls using named parameters in PHP 8.0+, this will easily lead to confusion. To avoid that, it is recommended not to use reserved keywords as function parameter names.

This commit renames the $default parameter to $default_value in WP_List_Table::get_items_per_page().

Follow-up to [52946], [52996], [52997], [52998], [53003], [53014], [53029].

Props jrf, aristath, poena, justinahinon, SergeyBiryukov.
See #55327.

File:

• trunk/src/wp-admin/includes/class-wp-list-table.php (modified) (1 diff)

trunk/src/wp-admin/includes/class-wp-list-table.php

@@ -825 +825 @@
      *
      * @param string $option
-     * @param int    $default
+     * @param int    $default_value
      * @return int
      */
-    protected function get_items_per_page( $option, $default = 20 ) {
+    protected function get_items_per_page( $option, $default_value = 20 ) {
         $per_page = (int) get_user_option( $option );
         if ( empty( $per_page ) || $per_page < 1 ) {
-            $per_page = $default;
+            $per_page = $default_value;
         }