Changeset 53044 for trunk/tests/phpunit/tests/functions.php

Timestamp:

04/01/2022 03:38:55 AM (3 years ago)

Author:

peterwilsoncc

Message:

Formatting: Account for HTML entities in wp_extract_urls().

Prevent wp_extract_urls() trimming HTML entities within URLs. Correctly escaped URLs such as ​https://youtube.com/watch?v=dQw4w9WgXcQ&t=1 will now be extracted as ​https://youtube.com/watch?v=dQw4w9WgXcQ&t=1 rather than truncated.

Props trex005, voldemortensen, johnbillion, ironprogrammer, costdev, hellofromtonya.
Fixes #30580

File:

• trunk/tests/phpunit/tests/functions.php (modified) (3 diffs)

trunk/tests/phpunit/tests/functions.php

@@ -991 +991 @@
             'http://www.woo.com/video?v=exvUH2qKLTU',
             'http://taco.com?burrito=enchilada#guac',
+            'http://example.org/?post_type=post&p=4',
+            'http://example.org/?post_type=post&p=5',
+            'http://example.org/?post_type=post&p=6',
+            'http://typo-in-query.org/?foo=bar&ampbaz=missing_semicolon',
         );
 
@@ -1053 +1057 @@
 
             http://taco.com?burrito=enchilada#guac
+
+            http://example.org/?post_type=post&p=4
+            http://example.org/?post_type=post&p=5
+            http://example.org/?post_type=post&p=6
+
+            http://typo-in-query.org/?foo=bar&ampbaz=missing_semicolon
         ';
 
@@ -1095 +1105 @@
         $this->assertCount( 8, $urls );
         $this->assertSame( array_slice( $original_urls, 0, 8 ), $urls );
+    }
+
+    /**
+     * Tests for backward compatibility of `wp_extract_urls` to remove unused semicolons.
+     *
+     * @ticket 30580
+     *
+     * @covers ::wp_extract_urls
+     */
+    public function test_wp_extract_urls_remove_semicolon() {
+        $expected = array(
+            'http://typo.com',
+            'http://example.org/?post_type=post&p=8',
+        );
+        $actual   = wp_extract_urls(
+            '
+                http://typo.com;
+                http://example.org/?post_type=;p;o;s;t;&p=8;
+            '
+        );
+
+        $this->assertSame( $expected, $actual );
     }