Changeset 53077 for trunk/.github/workflows/slack-notifications.yml

Timestamp:

04/05/2022 01:18:53 PM (3 years ago)

Author:

desrosj

Message:

Build/Test Tools: Prevent error when workflows run for new branches and tags.

This fixes a JavaScript error in the Slack notifications workflow. This was causing the first workflow run for each workflow in a new branch or tag to be reported as a failure, even if the important parts of the workflow succeed.

When running a workflow for the first time, a default of failure is now used for the previous outcome. This will trigger a success notification to be sent to report successful branching/tagging.

Props davidbaumwald.
Fixes #54742.

File:

• trunk/.github/workflows/slack-notifications.yml (modified) (1 diff)

trunk/.github/workflows/slack-notifications.yml

@@ -95 +95 @@
               page: 2,
             });
-            return previous_runs.data.workflow_runs[0].conclusion;
+
+            if ( previous_runs.data.total_count > 0 ) {
+              return previous_runs.data.workflow_runs[0].conclusion;
+            } else {
+              // Use failure so all first time runs for a branch or tag are reported to Slack.
+              return 'failure';
+            }
 
       - name: Store previous conclusion as an output