Changeset 53096 for trunk/src/wp-admin/includes/class-wp-posts-list-table.php

Timestamp:

04/07/2022 04:42:11 PM (4 years ago)

Author:

joedolson

Message:

Quick/Bulk Edit: Fix initial focus and keyboard operability.

Fix the quick and bulk edit forms to set an appropriate initial focus, use native HTML controls for all interactions, and set appropriate labels for controls. Improve the semantics of HTML wrappers so lists are enumerable by screen readers.

Props afercia, azaozz.
Fixes #35483.

File:

• trunk/src/wp-admin/includes/class-wp-posts-list-table.php (modified) (3 diffs)

trunk/src/wp-admin/includes/class-wp-posts-list-table.php

@@ -1612 +1612 @@
             <tr id="<?php echo $bulk ? 'bulk-edit' : 'inline-edit'; ?>" class="<?php echo $classes; ?>" style="display: none">
             <td colspan="<?php echo $this->get_column_count(); ?>" class="colspanchange">
-
+            <div class="inline-edit-wrapper" role="region" aria-labelledby="inline-edit-legend">
             <fieldset class="inline-edit-col-left">
-                <legend class="inline-edit-legend"><?php echo $bulk ? __( 'Bulk Edit' ) : __( 'Quick Edit' ); ?></legend>
+                <legend class="inline-edit-legend" id="inline-edit-legend"><?php echo $bulk ? __( 'Bulk Edit' ) : __( 'Quick Edit' ); ?></legend>
                 <div class="inline-edit-col">
 
@@ -1829 +1829 @@
                         <?php if ( current_user_can( $taxonomy->cap->assign_terms ) ) : ?>
                             <?php $taxonomy_name = esc_attr( $taxonomy->name ); ?>
-
+                            <div class="inline-edit-tags-wrap">
                             <label class="inline-edit-tags">
                                 <span class="title"><?php echo esc_html( $taxonomy->labels->name ); ?></span>
-                                <textarea data-wp-taxonomy="<?php echo $taxonomy_name; ?>" cols="22" rows="1" name="tax_input[<?php echo $taxonomy_name; ?>]" class="tax_input_<?php echo $taxonomy_name; ?>"></textarea>
+                                <textarea data-wp-taxonomy="<?php echo $taxonomy_name; ?>" cols="22" rows="1" name="tax_input[<?php echo esc_attr( $taxonomy->name ); ?>]" class="tax_input_<?php echo esc_attr( $taxonomy->name ); ?>" aria-describedby="inline-edit-<?php echo esc_attr( $taxonomy->name ); ?>-desc"></textarea>
                             </label>
-
+                            <p class="howto" id="inline-edit-<?php echo esc_attr( $taxonomy->name ); ?>-desc"><?php echo esc_html( $taxonomy->labels->separate_items_with_commas ); ?></p>
+                            </div>
                         <?php endif; // current_user_can( 'assign_terms' ) ?>
 
@@ -2031 +2032 @@
                 </div>
             </div>
+        </div> <!-- end of .inline-edit-wrapper -->
 
             </td></tr>