Changeset 53122

Timestamp:

04/11/2022 04:27:11 AM (3 years ago)

Author:

peterwilsoncc

Message:

Upgrade/Install/Users: Prevent JS bug filling new passwords.

A JavaScript race condition was throwing an error and preventing passwords from being set if the zxcvbn library loaded earlier than expected. This could prevent the installation of WordPress or the creation/updating of user accounts.

Props adi64bit, afragen, agepcom, audrasjb, bedas, brookedot, cbigler, charlyox, costdev, desrosj, drago239, Eric3D, espiat, jadpm, jrf, justinahinon, kubiq, lkraav, michelangelovandam, mirkolofio, mkox, peterwilsoncc, poena, sbossarte, sebastienserre, SergeyBiryukov, Synchro, thomasplevy, walbo, waterfire, wpmakenorg.
Fixes #53974, #52086.

File:

• trunk/src/js/_enqueues/admin/user-profile.js (modified) (2 diffs)

trunk/src/js/_enqueues/admin/user-profile.js

@@ -33 +33 @@
         }
 
+        /*
+         * This works around a race condition when zxcvbn loads quickly and
+         * causes `generatePassword()` to run prior to the toggle button being
+         * bound.
+         */
+        bindToggleButton();
+
         // Install screen.
         if ( 1 !== parseInt( $toggleButton.data( 'start-masked' ), 10 ) ) {
@@ -83 +90 @@
 
     function bindToggleButton() {
+        if ( !! $toggleButton ) {
+            // Do not rebind.
+            return;
+        }
         $toggleButton = $pass1Row.find('.wp-hide-pw');
         $toggleButton.show().on( 'click', function () {