Changeset 53124

Timestamp:

04/11/2022 04:49:29 AM (4 years ago)

Author:

peterwilsoncc

Message:

Plugins: Update item count when plugin deleted.

Update the item count, "N items", on the plugin list when a plugin is deleted. This matches the live updating of various other counts on the screen.

Props mitogh, costdev, azouamauriac, swissspidy, kebbet.
Fixes #55316.

Location:

trunk/src

Files:

• js/_enqueues/wp/updates.js (modified) (4 diffs)
• wp-includes/script-loader.php (modified) (1 diff)

trunk/src/js/_enqueues/wp/updates.js

@@ -35 +35 @@
                 _x = wp.i18n._x,
                 _n = wp.i18n._n,
+                _nx = wp.i18n._nx,
                 sprintf = wp.i18n.sprintf;
 
@@ -971 +972 @@
                                 $views           = $( '.subsubsub' ),
                                 $pluginRow       = $( this ),
+                                $currentView     = $views.find( '[aria-current="page"]' ),
+                                $itemsCount      = $( '.displaying-num' ),
                                 columnCount      = $form.find( 'thead th:not(.hidden), thead td' ).length,
                                 pluginDeletedRow = wp.template( 'item-deleted-row' ),
@@ -978 +981 @@
                                  * @type {Object}
                                  */
-                                plugins          = settings.plugins;
+                                plugins          = settings.plugins,
+                                remainingCount;
 
                         // Add a success message after deleting a plugin.
@@ -1057 +1061 @@
                                         $form.find( '#the-list' ).append( '<tr class="no-items"><td class="colspanchange" colspan="' + columnCount + '">' + __( 'No plugins are currently available.' ) + '</td></tr>' );
                                 }
+                        }
+
+                        if ( $itemsCount.length && $currentView.length ) {
+                                remainingCount = plugins[ $currentView.parent( 'li' ).attr('class') ].length;
+                                $itemsCount.text(
+                                        sprintf(
+                                                /* translators: %s: The remaining number of plugins. */
+                                                _nx( '%s item', '%s items', 'plugin/plugins', remainingCount ),
+                                                remainingCount
+                                        )
+                                );
                         }
                 } );

trunk/src/wp-includes/script-loader.php

@@ -1341 +1341 @@
                 $scripts->set_translations( 'privacy-tools' );
 
-                $scripts->add( 'updates', "/wp-admin/js/updates$suffix.js", array( 'common', 'jquery', 'wp-util', 'wp-a11y', 'wp-sanitize' ), false, 1 );
+                $scripts->add( 'updates', "/wp-admin/js/updates$suffix.js", array( 'common', 'jquery', 'wp-util', 'wp-a11y', 'wp-sanitize', 'wp-i18n' ), false, 1 );
                 $scripts->set_translations( 'updates' );
                 did_action( 'init' ) && $scripts->localize(