Changeset 53125 for trunk/src/wp-includes/general-template.php

Timestamp:

04/11/2022 05:01:04 AM (4 years ago)

Author:

peterwilsoncc

Message:

Feeds: Remove comment feed HTML headers when empty.

Remove the link[rel=alternate] element from the HTML header when the comment feeds are disabled. Previously the HTML element was output with an empty href attribute.

The element is removed if get_post_comments_feed_link() returns an empty string or the feed is disabled via the feed_links_show_comments_feed filter.

Props barryceelen, audrasjb, costdev, rachelbaker, Boniu91.
Fixes #54703.

File:

• trunk/src/wp-includes/general-template.php (modified) (1 diff)

trunk/src/wp-includes/general-template.php

@@ -3154 +3154 @@
         $post = get_post( $id );
 
-        if ( comments_open() || pings_open() || $post->comment_count > 0 ) {
-            $title = sprintf( $args['singletitle'], get_bloginfo( 'name' ), $args['separator'], the_title_attribute( array( 'echo' => false ) ) );
-            $href  = get_post_comments_feed_link( $post->ID );
+        /** This filter is documented in wp-includes/general-template.php */
+        $show_comments_feed = apply_filters( 'feed_links_show_comments_feed', true );
+
+        if ( $show_comments_feed && ( comments_open() || pings_open() || $post->comment_count > 0 ) ) {
+            $title     = sprintf( $args['singletitle'], get_bloginfo( 'name' ), $args['separator'], the_title_attribute( array( 'echo' => false ) ) );
+            $feed_link = get_post_comments_feed_link( $post->ID );
+
+            if ( $feed_link ) {
+                $href = $feed_link;
+            }
         }
     } elseif ( is_post_type_archive() ) {