Changeset 53174

Timestamp:

04/13/2022 04:12:51 PM (3 years ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Rename parameters that use reserved keywords in wp-admin/includes/class-wp-terms-list-table.php.

While using reserved PHP keywords as parameter name labels is allowed, in the context of function calls using named parameters in PHP 8.0+, this will easily lead to confusion. To avoid that, it is recommended not to use reserved keywords as function parameter names.

This commit renames the $parent parameter to $parent_term in WP_Terms_List_Table::_rows().

Follow-up to [52946], [52996], [52997], [52998], [53003], [53014], [53029], [53039], [53116], [53117], [53137].

Props jrf, aristath, poena, justinahinon, SergeyBiryukov.
See #55327.

File:

• trunk/src/wp-admin/includes/class-wp-terms-list-table.php (modified) (2 diffs)

trunk/src/wp-admin/includes/class-wp-terms-list-table.php

@@ -263 +263 @@
      * @param int    $per_page
      * @param int    $count
-     * @param int    $parent
+     * @param int    $parent_term
      * @param int    $level
      */
-    private function _rows( $taxonomy, $terms, &$children, $start, $per_page, &$count, $parent = 0, $level = 0 ) {
+    private function _rows( $taxonomy, $terms, &$children, $start, $per_page, &$count, $parent_term = 0, $level = 0 ) {
 
         $end = $start + $per_page;
@@ -276 +276 @@
             }
 
-            if ( $term->parent !== $parent && empty( $_REQUEST['s'] ) ) {
+            if ( $term->parent !== $parent_term && empty( $_REQUEST['s'] ) ) {
                 continue;
             }