Changeset 53175 for trunk/src/wp-includes/class-wp-query.php

Timestamp:

04/14/2022 12:02:31 AM (3 years ago)

Author:

SergeyBiryukov

Message:

Query: Restore late compact() call for SQL clauses in wp-includes/class-wp-*-query.php.

This addresses a backward compatibility break where posts_groupby and other filters were applied, but their results were subsequently discarded and earlier values were used instead.

Follow-up to [52974].

Props nextend_ramona.
See #54728, ​#meta6273.

File:

• trunk/src/wp-includes/class-wp-query.php (modified) (2 diffs)

trunk/src/wp-includes/class-wp-query.php

@@ -2754 +2754 @@
         }
 
-        $clauses = compact( 'where', 'groupby', 'join', 'orderby', 'distinct', 'fields', 'limits' );
+        $clauses = array( 'where', 'groupby', 'join', 'orderby', 'distinct', 'fields', 'limits' );
 
         /*
@@ -2856 +2856 @@
              * @param WP_Query $query   The WP_Query instance (passed by reference).
              */
-            $clauses = (array) apply_filters_ref_array( 'posts_clauses', array( $clauses, &$this ) );
+            $clauses = (array) apply_filters_ref_array( 'posts_clauses', array( compact( $clauses ), &$this ) );
 
             $where    = isset( $clauses['where'] ) ? $clauses['where'] : '';