Changeset 53175 for trunk/src/wp-includes/class-wp-site-query.php

Timestamp:

04/14/2022 12:02:31 AM (4 years ago)

Author:

SergeyBiryukov

Message:

Query: Restore late compact() call for SQL clauses in wp-includes/class-wp-*-query.php.

This addresses a backward compatibility break where posts_groupby and other filters were applied, but their results were subsequently discarded and earlier values were used instead.

Follow-up to [52974].

Props nextend_ramona.
See #54728, ​#meta6273.

File:

• trunk/src/wp-includes/class-wp-site-query.php (modified) (2 diffs)

trunk/src/wp-includes/class-wp-site-query.php

@@ -647 +647 @@
         $where = implode( ' AND ', $this->sql_clauses['where'] );
 
-        $clauses = compact( 'fields', 'join', 'where', 'orderby', 'limits', 'groupby' );
+        $clauses = array( 'fields', 'join', 'where', 'orderby', 'limits', 'groupby' );
 
         /**
@@ -657 +657 @@
          * @param WP_Site_Query $query   Current instance of WP_Site_Query (passed by reference).
          */
-        $clauses = apply_filters_ref_array( 'sites_clauses', array( $clauses, &$this ) );
+        $clauses = apply_filters_ref_array( 'sites_clauses', array( compact( $clauses ), &$this ) );
 
         $fields  = isset( $clauses['fields'] ) ? $clauses['fields'] : '';