Changeset 53181

Timestamp:

04/14/2022 01:24:59 PM (2 years ago)

Author:

audrasjb

Message:

Plugins: Avoid translating empty plugin headers.

This change aims to avoid unnecessarily translating empty strings from plugin headers, by removing empty fields from translation process in _get_plugin_data_markup_translate().

Props Chouby, johnbillion, audrasjb.
Fixes #54586.

File:

• trunk/src/wp-admin/includes/plugin.php (modified) (1 diff)

trunk/src/wp-admin/includes/plugin.php

@@ -156 +156 @@
         if ( $textdomain ) {
             foreach ( array( 'Name', 'PluginURI', 'Description', 'Author', 'AuthorURI', 'Version' ) as $field ) {
-                // phpcs:ignore WordPress.WP.I18n.LowLevelTranslationFunction,WordPress.WP.I18n.NonSingularStringLiteralText,WordPress.WP.I18n.NonSingularStringLiteralDomain
-                $plugin_data[ $field ] = translate( $plugin_data[ $field ], $textdomain );
+                if ( ! empty( $plugin_data[ $field ] ) ) {
+                    // phpcs:ignore WordPress.WP.I18n.LowLevelTranslationFunction,WordPress.WP.I18n.NonSingularStringLiteralText,WordPress.WP.I18n.NonSingularStringLiteralDomain
+                    $plugin_data[ $field ] = translate( $plugin_data[ $field ], $textdomain );
+                }
             }
         }