Changeset 53185

Timestamp:

04/15/2022 10:50:15 AM (3 years ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Rename parameters that use reserved keywords in wp-admin/includes/list-table.php.

While using reserved PHP keywords as parameter name labels is allowed, in the context of function calls using named parameters in PHP 8.0+, this will easily lead to confusion. To avoid that, it is recommended not to use reserved keywords as function parameter names.

This commit renames the $class parameter to $class_name in _get_list_table().

Follow-up to [52946], [52996], [52997], [52998], [53003], [53014], [53029], [53039], [53116], [53117], [53137], [53174], [53184].

Props jrf, aristath, poena, justinahinon, SergeyBiryukov.
See #55327.

File:

• trunk/src/wp-admin/includes/list-table.php (modified) (3 diffs)

trunk/src/wp-admin/includes/list-table.php

@@ -16 +16 @@
  * @global string $hook_suffix
  *
- * @param string $class The type of the list table, which is the class name.
- * @param array  $args  Optional. Arguments to pass to the class. Accepts 'screen'.
+ * @param string $class_name The type of the list table, which is the class name.
+ * @param array  $args       Optional. Arguments to pass to the class. Accepts 'screen'.
  * @return WP_List_Table|false List table object on success, false if the class does not exist.
  */
-function _get_list_table( $class, $args = array() ) {
+function _get_list_table( $class_name, $args = array() ) {
     $core_classes = array(
         // Site Admin.
@@ -46 +46 @@
     );
 
-    if ( isset( $core_classes[ $class ] ) ) {
-        foreach ( (array) $core_classes[ $class ] as $required ) {
+    if ( isset( $core_classes[ $class_name ] ) ) {
+        foreach ( (array) $core_classes[ $class_name ] as $required ) {
             require_once ABSPATH . 'wp-admin/includes/class-wp-' . $required . '-list-table.php';
         }
@@ -59 +59 @@
         }
 
-        return new $class( $args );
+        return new $class_name( $args );
     }