Changeset 53193

Timestamp:

04/17/2022 02:08:54 PM (3 years ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Rename parameters that use reserved keywords in wp-admin/includes/menu.php.

While using reserved PHP keywords as parameter name labels is allowed, in the context of function calls using named parameters in PHP 8.0+, this will easily lead to confusion. To avoid that, it is recommended not to use reserved keywords as function parameter names.

This commit:

• Renames the $class parameter to $classes in add_cssclass().
• Renames the $add parameter to $class_to_add for clarity.
• Includes minor code layout changes for better readability.

Follow-up to [52946], [52996], [52997], [52998], [53003], [53014], [53029], [53039], [53116], [53117], [53137], [53174], [53184], [53185], [53192].

Props jrf, aristath, poena, justinahinon, SergeyBiryukov.
See #55327.

File:

• trunk/src/wp-admin/includes/menu.php (modified) (2 diffs)

trunk/src/wp-admin/includes/menu.php

@@ -188 +188 @@
 
 /**
- * @param string $add
- * @param string $class
+ * @param string $class_to_add
+ * @param string $classes
  * @return string
  */
-function add_cssclass( $add, $class ) {
-    $class = empty( $class ) ? $add : $class .= ' ' . $add;
-    return $class;
+function add_cssclass( $class_to_add, $classes ) {
+    if ( empty( $classes ) ) {
+        return $class_to_add;
+    }
+
+    return $classes . ' ' . $class_to_add;
 }
 
@@ -352 +355 @@
 
 $menu = add_menu_classes( $menu );
+