Changeset 53195

Timestamp:

04/17/2022 02:39:15 PM (3 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use more descriptive variable names in add_menu_classes().

Follow-up to [9578], [53193], [53194].

See #54728.

File:

• trunk/src/wp-admin/includes/menu.php (modified) (2 diffs)

trunk/src/wp-admin/includes/menu.php

@@ -215 +215 @@
  */
 function add_menu_classes( $menu ) {
-    $first     = false;
-    $lastorder = false;
-    $i         = 0;
-    $mc        = count( $menu );
+    $first_item  = false;
+    $last_order  = false;
+    $items_count = count( $menu );
+    $i           = 0;
+
     foreach ( $menu as $order => $top ) {
         $i++;
@@ -224 +225 @@
         if ( 0 == $order ) { // Dashboard is always shown/single.
             $menu[0][4] = add_cssclass( 'menu-top-first', $top[4] );
-            $lastorder  = 0;
+            $last_order = 0;
             continue;
         }
 
-        if ( 0 === strpos( $top[2], 'separator' ) && false !== $lastorder ) { // If separator.
-            $first                 = true;
-            $c                     = $menu[ $lastorder ][4];
-            $menu[ $lastorder ][4] = add_cssclass( 'menu-top-last', $c );
+        if ( 0 === strpos( $top[2], 'separator' ) && false !== $last_order ) { // If separator.
+            $first_item             = true;
+            $classes                = $menu[ $last_order ][4];
+            $menu[ $last_order ][4] = add_cssclass( 'menu-top-last', $classes );
             continue;
         }
 
-        if ( $first ) {
-            $c                 = $menu[ $order ][4];
-            $menu[ $order ][4] = add_cssclass( 'menu-top-first', $c );
-            $first             = false;
-        }
-
-        if ( $mc == $i ) { // Last item.
-            $c                 = $menu[ $order ][4];
-            $menu[ $order ][4] = add_cssclass( 'menu-top-last', $c );
-        }
-
-        $lastorder = $order;
+        if ( $first_item ) {
+            $classes           = $menu[ $order ][4];
+            $menu[ $order ][4] = add_cssclass( 'menu-top-first', $classes );
+            $first_item        = false;
+        }
+
+        if ( $i == items_count ) { // Last item.
+            $classes           = $menu[ $order ][4];
+            $menu[ $order ][4] = add_cssclass( 'menu-top-last', $classes );
+        }
+
+        $last_order = $order;
     }