Changeset 53199

Timestamp:

04/17/2022 05:24:27 PM (4 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Simplify long conditions in xfn_check().

Add some comments for clarity.

Follow-up to [2051], [4990], [53198].

See #54728.

File:

• trunk/src/wp-admin/includes/meta-boxes.php (modified) (3 diffs)

trunk/src/wp-admin/includes/meta-boxes.php

@@ -1189 +1189 @@
  * @param string $xfn_relationship
  * @param string $xfn_value
- * @param mixed  $deprecated Never used.
+ * @param mixed  $deprecated       Never used.
  */
 function xfn_check( $xfn_relationship, $xfn_value = '', $deprecated = '' ) {
@@ -1198 +1198 @@
         }
 
-        $link_rel = isset( $link->link_rel ) ? $link->link_rel : ''; // In PHP 5.3: $link_rel = $link->link_rel ?: '';
-        $rels     = preg_split( '/\s+/', $link_rel );
-
-        if ( '' !== $xfn_value && in_array( $xfn_value, $rels, true ) ) {
+        $link_rel  = isset( $link->link_rel ) ? $link->link_rel : ''; // In PHP 5.3: $link_rel = $link->link_rel ?: '';
+        $link_rels = preg_split( '/\s+/', $link_rel );
+
+        // Mark the specified value as checked if it matches the link relationship.
+        if ( '' !== $xfn_value && in_array( $xfn_value, $link_rels, true ) ) {
                 echo ' checked="checked"';
         }
 
         if ( '' === $xfn_value ) {
+                // Mark the 'none' value as checked if the link does not match the specified relationship.
                 if ( 'family' === $xfn_relationship
-                        && strpos( $link_rel, 'child' ) === false
-                        && strpos( $link_rel, 'parent' ) === false
-                        && strpos( $link_rel, 'sibling' ) === false
-                        && strpos( $link_rel, 'spouse' ) === false
-                        && strpos( $link_rel, 'kin' ) === false
+                        && ! array_intersect( $link_rels, array( 'child', 'parent', 'sibling', 'spouse', 'kin' ) )
                 ) {
                         echo ' checked="checked"';
@@ -1217 +1215 @@
 
                 if ( 'friendship' === $xfn_relationship
-                        && strpos( $link_rel, 'friend' ) === false
-                        && strpos( $link_rel, 'acquaintance' ) === false
-                        && strpos( $link_rel, 'contact' ) === false ) {
-                        echo ' checked="checked"';
-                }
-
-                if ( 'geographical' === $xfn_relationship
-                        && strpos( $link_rel, 'co-resident' ) === false
-                        && strpos( $link_rel, 'neighbor' ) === false
+                        && ! array_intersect( $link_rels, array( 'friend', 'acquaintance', 'contact' ) )
                 ) {
                         echo ' checked="checked"';
                 }
 
+                if ( 'geographical' === $xfn_relationship
+                        && ! array_intersect( $link_rels, array( 'co-resident', 'neighbor' ) )
+                ) {
+                        echo ' checked="checked"';
+                }
+
+                // Mark the 'me' value as checked if it matches the link relationship.
                 if ( 'identity' === $xfn_relationship
-                        && in_array( 'me', $rels, true )
+                        && in_array( 'me', $link_rels, true )
                 ) {
                         echo ' checked="checked"';