Changeset 53228

Timestamp:

04/20/2022 08:11:34 AM (3 years ago)

Author:

audrasjb

Message:

Media: Remove attachment_fields_to_save filter and deprecate image_attachment_fields_to_save().

This filter prevented removing attachment titles. This changeset removes the filter and deprecates the related function since it is no longer used.

Props dromero20, desrosj, Junaidkbr, francina, antpb, audrasjb, aadilali, etaproducto, azouamauriac, Boniu91, SergeyBiryukov.
Fixes #39108.

Location:

trunk/src/wp-admin/includes

Files:

• admin-filters.php (modified) (1 diff)
• deprecated.php (modified) (1 diff)
• media.php (modified) (1 diff)

trunk/src/wp-admin/includes/admin-filters.php

@@ -31 +31 @@
 add_filter( 'async_upload_video', 'get_media_item', 10, 2 );
 add_filter( 'async_upload_file', 'get_media_item', 10, 2 );
-
-add_filter( 'attachment_fields_to_save', 'image_attachment_fields_to_save', 10, 2 );
 
 add_filter( 'media_upload_gallery', 'media_upload_gallery' );

trunk/src/wp-admin/includes/deprecated.php

@@ -1568 +1568 @@
     _deprecated_function( __FUNCTION__, '5.3.0' );
 }
+
+/**
+ * Was used to filter input from media_upload_form_handler() and to assign a default
+ * post_title from the file name if none supplied.
+ *
+ * @since 2.5.0
+ * @deprecated 6.0.0
+ *
+ * @param array $post       The WP_Post attachment object converted to an array.
+ * @param array $attachment An array of attachment metadata.
+ * @return array Attachment post object converted to an array.
+ */
+function image_attachment_fields_to_save( $post, $attachment ) {
+    _deprecated_function( __FUNCTION__, '6.0.0' );
+
+    return $post;
+}

trunk/src/wp-admin/includes/media.php

@@ -1320 +1320 @@
     unset( $form_fields['image_url'] );
     return $form_fields;
-}
-
-/**
- * Filters input from media_upload_form_handler() and assigns a default
- * post_title from the file name if none supplied.
- *
- * Illustrates the use of the {@see 'attachment_fields_to_save'} filter
- * which can be used to add default values to any field before saving to DB.
- *
- * @since 2.5.0
- *
- * @param array $post       The WP_Post attachment object converted to an array.
- * @param array $attachment An array of attachment metadata.
- * @return array Filtered attachment post object.
- */
-function image_attachment_fields_to_save( $post, $attachment ) {
-    if ( 'image' === substr( $post['post_mime_type'], 0, 5 ) ) {
-        if ( strlen( trim( $post['post_title'] ) ) == 0 ) {
-            $attachment_url                           = ( isset( $post['attachment_url'] ) ) ? $post['attachment_url'] : $post['guid'];
-            $post['post_title']                       = preg_replace( '/\.\w+$/', '', wp_basename( $attachment_url ) );
-            $post['errors']['post_title']['errors'][] = __( 'Empty Title filled from filename.' );
-        }
-    }
-
-    return $post;
 }