Changeset 53230 for trunk/src/wp-admin/includes/upgrade.php

Timestamp:

04/20/2022 10:44:46 AM (3 years ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Rename parameters that use reserved keywords in wp-admin/includes/upgrade.php.

While using reserved PHP keywords as parameter name labels is allowed, in the context of function calls using named parameters in PHP 8.0+, this will easily lead to confusion. To avoid that, it is recommended not to use reserved keywords as function parameter names.

This commit renames the $public parameter to $is_public in wp_install().

Follow-up to [52946], [52996], [52997], [52998], [53003], [53014], [53029], [53039], [53116], [53117], [53137], [53174], [53184], [53185], [53192], [53193], [53198], [53203], [53207], [53215], [53216], [53220].

Props jrf, aristath, poena, justinahinon, SergeyBiryukov.
See #55327.

File:

• trunk/src/wp-admin/includes/upgrade.php (modified) (4 diffs)

trunk/src/wp-admin/includes/upgrade.php

@@ -32 +32 @@
      * @param string $user_name     User's username.
      * @param string $user_email    User's email.
-     * @param bool   $public        Whether site is public.
+     * @param bool   $is_public     Whether the site is public.
      * @param string $deprecated    Optional. Not used.
      * @param string $user_password Optional. User's chosen password. Default empty (random password).
@@ -45 +45 @@
      * }
      */
-    function wp_install( $blog_title, $user_name, $user_email, $public, $deprecated = '', $user_password = '', $language = '' ) {
+    function wp_install( $blog_title, $user_name, $user_email, $is_public, $deprecated = '', $user_password = '', $language = '' ) {
         if ( ! empty( $deprecated ) ) {
             _deprecated_argument( __FUNCTION__, '2.6.0' );
@@ -58 +58 @@
         update_option( 'blogname', $blog_title );
         update_option( 'admin_email', $user_email );
-        update_option( 'blog_public', $public );
+        update_option( 'blog_public', $is_public );
 
         // Freshness of site - in the future, this could get more specific about actions taken, perhaps.
@@ -72 +72 @@
 
         // If not a public site, don't ping.
-        if ( ! $public ) {
+        if ( ! $is_public ) {
             update_option( 'default_pingback_flag', 0 );
         }