Changeset 53233 for trunk/src/wp-includes/class-wp.php

Timestamp:

04/20/2022 12:46:01 PM (2 years ago)

Author:

audrasjb

Message:

Feeds: Use latest comment date for the Last-Modified header of comments feed.

Previously, the Last-Modified header of comments feed was using the date/time of the last comment. This behavior was breaking caching and causing feed readers to believe there is no new content even when there might be new posts.

This commit changes this behavior to use the newest date from both get_lastcommentmodified() and get_lastpostmodified() functions instead of only using the result from get_lastcommentmodified().

Props xiven, mauteri, costdev, audrasjb.
Fixes #47968.

File:

• trunk/src/wp-includes/class-wp.php (modified) (3 diffs)

trunk/src/wp-includes/class-wp.php

@@ -414 +414 @@
         $status        = null;
         $exit_required = false;
+        $date_format   = 'D, d M Y H:i:s';
 
         if ( is_user_logged_in() ) {
@@ -421 +422 @@
             $expires = 10 * MINUTE_IN_SECONDS;
 
-            $headers['Expires']       = gmdate( 'D, d M Y H:i:s', time() + $expires );
+            $headers['Expires']       = gmdate( $date_format, time() + $expires );
             $headers['Cache-Control'] = sprintf(
                 'max-age=%d, must-revalidate',
@@ -460 +461 @@
                 )
             ) {
-                $wp_last_modified = mysql2date( 'D, d M Y H:i:s', get_lastcommentmodified( 'GMT' ), false );
+                $wp_last_modified_post    = mysql2date( $date_format, get_lastpostmodified( 'GMT' ), false );
+                $wp_last_modified_comment = mysql2date( $date_format, get_lastcommentmodified( 'GMT' ), false );
+                if ( strtotime( $wp_last_modified_post ) > strtotime( $wp_last_modified_comment ) ) {
+                    $wp_last_modified = $wp_last_modified_post;
+                } else {
+                    $wp_last_modified = $wp_last_modified_comment;
+                }
             } else {
-                $wp_last_modified = mysql2date( 'D, d M Y H:i:s', get_lastpostmodified( 'GMT' ), false );
+                $wp_last_modified = mysql2date( $date_format, get_lastpostmodified( 'GMT' ), false );
             }
 
             if ( ! $wp_last_modified ) {
-                $wp_last_modified = gmdate( 'D, d M Y H:i:s' );
+                $wp_last_modified = gmdate( $date_format );
             }