Make WordPress Core


Ignore:
Timestamp:
04/20/2022 02:22:21 PM (2 years ago)
Author:
SergeyBiryukov
Message:

Code Modernization: Rename parameters that use reserved keywords in bundled themes.

While using reserved PHP keywords as parameter name labels is allowed, in the context of function calls using named parameters in PHP 8.0+, this will easily lead to confusion. To avoid that, it is recommended not to use reserved keywords as function parameter names.

This commit:

  • Renames the $class parameter to $css_class in:
    • twentysixteen_excerpt()
    • twentynineteen_post_classes()
  • Renames the $echo parameter to $display in:
    • twentythirteen_entry_date()
    • twentytwenty_generate_css()
    • twentytwenty_site_logo()
    • twentytwenty_site_description()
    • twenty_twenty_one_generate_css()

Follow-up to [52946], [52996], [52997], [52998], [53003], [53014], [53029], [53039], [53116], [53117], [53137], [53174], [53184], [53185], [53192], [53193], [53198], [53203], [53207], [53215], [53216], [53220], [53230], [53232].

Props jrf, aristath, poena, justinahinon, SergeyBiryukov.
See #55327.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-content/themes/twentysixteen/inc/template-tags.php

    r47550 r53236  
    162162     * @since Twenty Sixteen 1.0
    163163     *
    164      * @param string $class Optional. Class string of the div element. Defaults to 'entry-summary'.
    165      */
    166     function twentysixteen_excerpt( $class = 'entry-summary' ) {
    167         $class = esc_attr( $class );
     164     * @param string $css_class Optional. Class string of the div element. Defaults to 'entry-summary'.
     165     */
     166    function twentysixteen_excerpt( $css_class = 'entry-summary' ) {
     167        $css_class = esc_attr( $css_class );
    168168
    169169        if ( has_excerpt() || is_search() ) :
    170170            ?>
    171             <div class="<?php echo $class; ?>">
     171            <div class="<?php echo $css_class; ?>">
    172172                <?php the_excerpt(); ?>
    173             </div><!-- .<?php echo $class; ?> -->
     173            </div><!-- .<?php echo $css_class; ?> -->
    174174            <?php
    175175        endif;
Note: See TracChangeset for help on using the changeset viewer.