Make WordPress Core


Ignore:
Timestamp:
04/20/2022 02:22:21 PM (22 months ago)
Author:
SergeyBiryukov
Message:

Code Modernization: Rename parameters that use reserved keywords in bundled themes.

While using reserved PHP keywords as parameter name labels is allowed, in the context of function calls using named parameters in PHP 8.0+, this will easily lead to confusion. To avoid that, it is recommended not to use reserved keywords as function parameter names.

This commit:

  • Renames the $class parameter to $css_class in:
    • twentysixteen_excerpt()
    • twentynineteen_post_classes()
  • Renames the $echo parameter to $display in:
    • twentythirteen_entry_date()
    • twentytwenty_generate_css()
    • twentytwenty_site_logo()
    • twentytwenty_site_description()
    • twenty_twenty_one_generate_css()

Follow-up to [52946], [52996], [52997], [52998], [53003], [53014], [53029], [53039], [53116], [53117], [53137], [53174], [53184], [53185], [53192], [53193], [53198], [53203], [53207], [53215], [53216], [53220], [53230], [53232].

Props jrf, aristath, poena, justinahinon, SergeyBiryukov.
See #55327.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-content/themes/twentythirteen/functions.php

    r52929 r53236  
    563563     * @since Twenty Thirteen 1.0
    564564     *
    565      * @param bool $echo (optional) Whether to echo the date. Default true.
     565     * @param bool $display (optional) Whether to display the date. Default true.
    566566     * @return string The HTML-formatted post date.
    567567     */
    568     function twentythirteen_entry_date( $echo = true ) {
     568    function twentythirteen_entry_date( $display = true ) {
    569569        if ( has_post_format( array( 'chat', 'status' ) ) ) {
    570570            /* translators: 1: Post format name, 2: Date. */
     
    583583        );
    584584
    585         if ( $echo ) {
     585        if ( $display ) {
    586586            echo $date;
    587587        }
Note: See TracChangeset for help on using the changeset viewer.