Changeset 53236 for trunk/src/wp-content/themes/twentytwenty/inc/custom-css.php

Timestamp:

04/20/2022 02:22:21 PM (3 years ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Rename parameters that use reserved keywords in bundled themes.

While using reserved PHP keywords as parameter name labels is allowed, in the context of function calls using named parameters in PHP 8.0+, this will easily lead to confusion. To avoid that, it is recommended not to use reserved keywords as function parameter names.

This commit:

• Renames the $class parameter to $css_class in:
  • twentysixteen_excerpt()
  • twentynineteen_post_classes()
• Renames the $echo parameter to $display in:
  • twentythirteen_entry_date()
  • twentytwenty_generate_css()
  • twentytwenty_site_logo()
  • twentytwenty_site_description()
  • twenty_twenty_one_generate_css()

Follow-up to [52946], [52996], [52997], [52998], [53003], [53014], [53029], [53039], [53116], [53117], [53137], [53174], [53184], [53185], [53192], [53193], [53198], [53203], [53207], [53215], [53216], [53220], [53230], [53232].

Props jrf, aristath, poena, justinahinon, SergeyBiryukov.
See #55327.

File:

• trunk/src/wp-content/themes/twentytwenty/inc/custom-css.php (modified) (2 diffs)

trunk/src/wp-content/themes/twentytwenty/inc/custom-css.php

@@ -20 +20 @@
      * @param string $prefix   The CSS prefix.
      * @param string $suffix   The CSS suffix.
-     * @param bool   $echo     Echo the styles.
+     * @param bool   $display  Output the styles.
      */
-    function twentytwenty_generate_css( $selector, $style, $value, $prefix = '', $suffix = '', $echo = true ) {
+    function twentytwenty_generate_css( $selector, $style, $value, $prefix = '', $suffix = '', $display = true ) {
 
         $return = '';
@@ -36 +36 @@
         $return = sprintf( '%s { %s: %s; }', $selector, $style, $prefix . $value . $suffix );
 
-        if ( $echo ) {
+        if ( $display ) {
 
             echo $return; // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped -- We need to double check this, but for now, we want to pass PHPCS ;)