Make WordPress Core


Ignore:
Timestamp:
04/20/2022 02:22:21 PM (2 years ago)
Author:
SergeyBiryukov
Message:

Code Modernization: Rename parameters that use reserved keywords in bundled themes.

While using reserved PHP keywords as parameter name labels is allowed, in the context of function calls using named parameters in PHP 8.0+, this will easily lead to confusion. To avoid that, it is recommended not to use reserved keywords as function parameter names.

This commit:

  • Renames the $class parameter to $css_class in:
    • twentysixteen_excerpt()
    • twentynineteen_post_classes()
  • Renames the $echo parameter to $display in:
    • twentythirteen_entry_date()
    • twentytwenty_generate_css()
    • twentytwenty_site_logo()
    • twentytwenty_site_description()
    • twenty_twenty_one_generate_css()

Follow-up to [52946], [52996], [52997], [52998], [53003], [53014], [53029], [53039], [53116], [53117], [53137], [53174], [53184], [53185], [53192], [53193], [53198], [53203], [53207], [53215], [53216], [53220], [53230], [53232].

Props jrf, aristath, poena, justinahinon, SergeyBiryukov.
See #55327.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-content/themes/twentytwentyone/inc/custom-css.php

    r51294 r53236  
    1818 * @param string $prefix   The CSS prefix.
    1919 * @param string $suffix   The CSS suffix.
    20  * @param bool   $echo     Echo the styles.
     20 * @param bool   $display  Output the styles.
    2121 * @return string
    2222 */
    23 function twenty_twenty_one_generate_css( $selector, $style, $value, $prefix = '', $suffix = '', $echo = true ) {
     23function twenty_twenty_one_generate_css( $selector, $style, $value, $prefix = '', $suffix = '', $display = true ) {
    2424
    2525    // Bail early if there is no $selector elements or properties and $value.
     
    3030    $css = sprintf( '%s { %s: %s; }', $selector, $style, $prefix . $value . $suffix );
    3131
    32     if ( $echo ) {
     32    if ( $display ) {
    3333        /*
    3434         * Note to reviewers: $css contains auto-generated CSS.
Note: See TracChangeset for help on using the changeset viewer.