Changeset 53240

Timestamp:

04/21/2022 09:03:05 PM (2 years ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Rename parameters that use reserved keywords in wp-includes/block-supports/border.php.

While using reserved PHP keywords as parameter name labels is allowed, in the context of function calls using named parameters in PHP 8.0+, this will easily lead to confusion. To avoid that, it is recommended not to use reserved keywords as function parameter names.

This commit renames the $default parameter to $default_value in wp_has_border_feature_support().

Follow-up to [52946], [52996], [52997], [52998], [53003], [53014], [53029], [53039], [53116], [53117], [53137], [53174], [53184], [53185], [53192], [53193], [53198], [53203], [53207], [53215], [53216], [53220], [53230], [53232], [53236], [53239].

Props jrf, aristath, poena, justinahinon, SergeyBiryukov.
See #55327.

File:

• trunk/src/wp-includes/block-supports/border.php (modified) (2 diffs)

trunk/src/wp-includes/block-supports/border.php

@@ -154 +154 @@
  * @access private
  *
- * @param WP_Block_Type $block_type Block type to check for support.
- * @param string        $feature    Name of the feature to check support for.
- * @param mixed         $default    Fallback value for feature support, defaults to false.
+ * @param WP_Block_Type $block_type    Block type to check for support.
+ * @param string        $feature       Name of the feature to check support for.
+ * @param mixed         $default_value Fallback value for feature support, defaults to false.
  * @return bool Whether the feature is supported.
  */
-function wp_has_border_feature_support( $block_type, $feature, $default = false ) {
+function wp_has_border_feature_support( $block_type, $feature, $default_value = false ) {
     // Check if all border support features have been opted into via `"__experimentalBorder": true`.
     if (
         property_exists( $block_type, 'supports' ) &&
-        ( true === _wp_array_get( $block_type->supports, array( '__experimentalBorder' ), $default ) )
+        ( true === _wp_array_get( $block_type->supports, array( '__experimentalBorder' ), $default_value ) )
     ) {
         return true;
@@ -170 +170 @@
     // Check if the specific feature has been opted into individually
     // via nested flag under `__experimentalBorder`.
-    return block_has_support( $block_type, array( '__experimentalBorder', $feature ), $default );
+    return block_has_support( $block_type, array( '__experimentalBorder', $feature ), $default_value );
 }